| Message ID | 1343026180-22236-5-git-send-email-aaron.lu@amd.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hello. On 07/23/2012 10:49 AM, Aaron Lu wrote: > When runtime resume a scsi device, if the device's driver has > implemented runtime resume callback, use that instead of the resume > callback. > sr driver needs this to properly do different things for system resume > and runtime resume. > Signed-off-by: Aaron Lu <aaron.lu@amd.com> > --- > drivers/scsi/scsi_pm.c | 14 +++++++++----- > drivers/scsi/sr.c | 21 +++++++++++++++++++++ > 2 files changed, 30 insertions(+), 5 deletions(-) > diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c > index d4201de..19bba47 100644 > --- a/drivers/scsi/scsi_pm.c > +++ b/drivers/scsi/scsi_pm.c > @@ -34,14 +34,18 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg) > return err; > } > > -static int scsi_dev_type_resume(struct device *dev) > +static int scsi_dev_type_resume(struct device *dev, bool runtime) > { > struct device_driver *drv; > int err = 0; > + int (*resume)(struct device *); > > drv = dev->driver; > - if (drv && drv->resume) > - err = drv->resume(dev); > + if (runtime && drv && drv->pm && drv->pm->runtime_resume) > + resume = drv->pm->runtime_resume; > + else > + resume = drv ? drv->resume : NULL; Call thru NULL pointer below will cause kernel oops. Is it your intention? > + err = resume(dev); WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, Jul 23, 2012 at 06:36:12PM +0400, Sergei Shtylyov wrote: > Hello. > > On 07/23/2012 10:49 AM, Aaron Lu wrote: > > > When runtime resume a scsi device, if the device's driver has > > implemented runtime resume callback, use that instead of the resume > > callback. > > > sr driver needs this to properly do different things for system resume > > and runtime resume. > > > Signed-off-by: Aaron Lu <aaron.lu@amd.com> > > --- > > drivers/scsi/scsi_pm.c | 14 +++++++++----- > > drivers/scsi/sr.c | 21 +++++++++++++++++++++ > > 2 files changed, 30 insertions(+), 5 deletions(-) > > > diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c > > index d4201de..19bba47 100644 > > --- a/drivers/scsi/scsi_pm.c > > +++ b/drivers/scsi/scsi_pm.c > > @@ -34,14 +34,18 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg) > > return err; > > } > > > > -static int scsi_dev_type_resume(struct device *dev) > > +static int scsi_dev_type_resume(struct device *dev, bool runtime) > > { > > struct device_driver *drv; > > int err = 0; > > + int (*resume)(struct device *); > > > > drv = dev->driver; > > - if (drv && drv->resume) > > - err = drv->resume(dev); > > + if (runtime && drv && drv->pm && drv->pm->runtime_resume) > > + resume = drv->pm->runtime_resume; > > + else > > + resume = drv ? drv->resume : NULL; > > Call thru NULL pointer below will cause kernel oops. Is it your intention? Oops, I forgot the if check here, thanks for pointing this out. -Aaron > > > + err = resume(dev); > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c index d4201de..19bba47 100644 --- a/drivers/scsi/scsi_pm.c +++ b/drivers/scsi/scsi_pm.c @@ -34,14 +34,18 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg) return err; } -static int scsi_dev_type_resume(struct device *dev) +static int scsi_dev_type_resume(struct device *dev, bool runtime) { struct device_driver *drv; int err = 0; + int (*resume)(struct device *); drv = dev->driver; - if (drv && drv->resume) - err = drv->resume(dev); + if (runtime && drv && drv->pm && drv->pm->runtime_resume) + resume = drv->pm->runtime_resume; + else + resume = drv ? drv->resume : NULL; + err = resume(dev); scsi_device_resume(to_scsi_device(dev)); dev_dbg(dev, "scsi resume: %d\n", err); return err; @@ -84,7 +88,7 @@ static int scsi_bus_resume_common(struct device *dev) * Resume it on behalf of child. */ pm_runtime_get_sync(dev->parent); - err = scsi_dev_type_resume(dev); + err = scsi_dev_type_resume(dev, false); pm_runtime_put_sync(dev->parent); } @@ -159,7 +163,7 @@ static int scsi_runtime_resume(struct device *dev) dev_dbg(dev, "scsi_runtime_resume\n"); if (scsi_is_sdev_device(dev)) - err = scsi_dev_type_resume(dev); + err = scsi_dev_type_resume(dev, true); /* Insert hooks here for targets, hosts, and transport classes */ diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 69c9e22..2f159aa 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -82,6 +82,11 @@ static int sr_remove(struct device *); static int sr_done(struct scsi_cmnd *); static int sr_suspend(struct device *dev, pm_message_t msg); static int sr_resume(struct device *dev); +static int sr_runtime_resume(struct device *dev); + +static struct dev_pm_ops sr_pm_ops = { + .runtime_resume = sr_runtime_resume, +}; static struct scsi_driver sr_template = { .owner = THIS_MODULE, @@ -91,6 +96,7 @@ static struct scsi_driver sr_template = { .remove = sr_remove, .suspend = sr_suspend, .resume = sr_resume, + .pm = &sr_pm_ops, }, .done = sr_done, }; @@ -215,6 +221,21 @@ static int sr_suspend(struct device *dev, pm_message_t msg) static int sr_resume(struct device *dev) { + struct scsi_cd *cd = dev_get_drvdata(dev); + + /* + * If ODD is runtime suspended before system pm, unblock disk + * events now since on system resume, we will fully resume it + * and set its rumtime status to active. + */ + if (pm_runtime_suspended(dev)) + disk_unblock_events(cd->disk); + + return 0; +} + +static int sr_runtime_resume(struct device *dev) +{ struct scsi_cd *cd; struct scsi_sense_hdr sshdr;
When runtime resume a scsi device, if the device's driver has implemented runtime resume callback, use that instead of the resume callback. sr driver needs this to properly do different things for system resume and runtime resume. Signed-off-by: Aaron Lu <aaron.lu@amd.com> --- drivers/scsi/scsi_pm.c | 14 +++++++++----- drivers/scsi/sr.c | 21 +++++++++++++++++++++ 2 files changed, 30 insertions(+), 5 deletions(-)