| Message ID | 1357140582-8151-4-git-send-email-eduardo.valentin@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
> -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Eduardo Valentin > Sent: Wednesday, January 02, 2013 9:00 PM > To: Zhang, Rui > Cc: R, Durgadoss; linux-pm@lists.linux-foundation.org; linux- > pm@vger.kernel.org; Eduardo Valentin > Subject: [PATCH RESEND 3/4] thermal: cleanup: use dev_* helper functions > > Change the logging messages to used dev_* helper functions. A good to have Change :-) > Reviewed-by: Durgadoss R <durgadoss.r@intel.com> Thanks, Durga > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/thermal/thermal_sys.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 70ce100..fba27c3 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -354,8 +354,9 @@ static void handle_critical_trips(struct > thermal_zone_device *tz, > tz->ops->notify(tz, trip, trip_type); > > if (trip_type == THERMAL_TRIP_CRITICAL) { > - pr_emerg("Critical temperature reached(%d C),shutting > down\n", > - tz->temperature / 1000); > + dev_emerg(&tz->device, > + "critical temperature reached(%d C),shutting > down\n", > + tz->temperature / 1000); > orderly_poweroff(true); > } > } > @@ -386,7 +387,8 @@ static void update_temperature(struct > thermal_zone_device *tz) > > ret = tz->ops->get_temp(tz, &temp); > if (ret) { > - pr_warn("failed to read out thermal zone %d\n", tz->id); > + dev_warn(&tz->device, "failed to read out thermal zone > %d\n", > + tz->id); > goto exit; > } > > @@ -1770,7 +1772,7 @@ int thermal_generate_netlink_event(struct > thermal_zone_device *tz, > > result = genlmsg_multicast(skb, 0, thermal_event_mcgrp.id, > GFP_ATOMIC); > if (result) > - pr_info("failed to send netlink event:%d\n", result); > + dev_err(&tz->device, "Failed to send netlink event:%d", > result); > > return result; > } > -- > 1.7.7.1.488.ge8e1c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2013-01-02 at 17:29 +0200, Eduardo Valentin wrote: > Change the logging messages to used dev_* helper functions. > > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> applied to thermal -next. thanks, rui > --- > drivers/thermal/thermal_sys.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 70ce100..fba27c3 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -354,8 +354,9 @@ static void handle_critical_trips(struct thermal_zone_device *tz, > tz->ops->notify(tz, trip, trip_type); > > if (trip_type == THERMAL_TRIP_CRITICAL) { > - pr_emerg("Critical temperature reached(%d C),shutting down\n", > - tz->temperature / 1000); > + dev_emerg(&tz->device, > + "critical temperature reached(%d C),shutting down\n", > + tz->temperature / 1000); > orderly_poweroff(true); > } > } > @@ -386,7 +387,8 @@ static void update_temperature(struct thermal_zone_device *tz) > > ret = tz->ops->get_temp(tz, &temp); > if (ret) { > - pr_warn("failed to read out thermal zone %d\n", tz->id); > + dev_warn(&tz->device, "failed to read out thermal zone %d\n", > + tz->id); > goto exit; > } > > @@ -1770,7 +1772,7 @@ int thermal_generate_netlink_event(struct thermal_zone_device *tz, > > result = genlmsg_multicast(skb, 0, thermal_event_mcgrp.id, GFP_ATOMIC); > if (result) > - pr_info("failed to send netlink event:%d\n", result); > + dev_err(&tz->device, "Failed to send netlink event:%d", result); > > return result; > } -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c index 70ce100..fba27c3 100644 --- a/drivers/thermal/thermal_sys.c +++ b/drivers/thermal/thermal_sys.c @@ -354,8 +354,9 @@ static void handle_critical_trips(struct thermal_zone_device *tz, tz->ops->notify(tz, trip, trip_type); if (trip_type == THERMAL_TRIP_CRITICAL) { - pr_emerg("Critical temperature reached(%d C),shutting down\n", - tz->temperature / 1000); + dev_emerg(&tz->device, + "critical temperature reached(%d C),shutting down\n", + tz->temperature / 1000); orderly_poweroff(true); } } @@ -386,7 +387,8 @@ static void update_temperature(struct thermal_zone_device *tz) ret = tz->ops->get_temp(tz, &temp); if (ret) { - pr_warn("failed to read out thermal zone %d\n", tz->id); + dev_warn(&tz->device, "failed to read out thermal zone %d\n", + tz->id); goto exit; } @@ -1770,7 +1772,7 @@ int thermal_generate_netlink_event(struct thermal_zone_device *tz, result = genlmsg_multicast(skb, 0, thermal_event_mcgrp.id, GFP_ATOMIC); if (result) - pr_info("failed to send netlink event:%d\n", result); + dev_err(&tz->device, "Failed to send netlink event:%d", result); return result; }
Change the logging messages to used dev_* helper functions. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- drivers/thermal/thermal_sys.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)