From patchwork Thu Jan 10 01:09:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aravind Gopalakrishnan X-Patchwork-Id: 1958131 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 4AF74DF2EB for ; Thu, 10 Jan 2013 01:09:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932463Ab3AJBJa (ORCPT ); Wed, 9 Jan 2013 20:09:30 -0500 Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14]:54570 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932323Ab3AJBJ2 (ORCPT ); Wed, 9 Jan 2013 20:09:28 -0500 Received: from mail116-va3-R.bigfish.com (10.7.14.249) by VA3EHSOBE014.bigfish.com (10.7.40.64) with Microsoft SMTP Server id 14.1.225.23; Thu, 10 Jan 2013 01:09:27 +0000 Received: from mail116-va3 (localhost [127.0.0.1]) by mail116-va3-R.bigfish.com (Postfix) with ESMTP id 8DC0480153; Thu, 10 Jan 2013 01:09:27 +0000 (UTC) X-Forefront-Antispam-Report: CIP:163.181.249.109; KIP:(null); UIP:(null); IPV:NLI; H:ausb3twp02.amd.com; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VPS0(zzzz1ee6h1de0h1202h1e76h1d1ah1d2ahzz8275bh8275dhz2dh668h839he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1155h) Received: from mail116-va3 (localhost.localdomain [127.0.0.1]) by mail116-va3 (MessageSwitch) id 135778016531156_8021; Thu, 10 Jan 2013 01:09:25 +0000 (UTC) Received: from VA3EHSMHS007.bigfish.com (unknown [10.7.14.235]) by mail116-va3.bigfish.com (Postfix) with ESMTP id BCB2114009C; Thu, 10 Jan 2013 01:09:24 +0000 (UTC) Received: from ausb3twp02.amd.com (163.181.249.109) by VA3EHSMHS007.bigfish.com (10.7.99.17) with Microsoft SMTP Server id 14.1.225.23; Thu, 10 Jan 2013 01:09:21 +0000 X-WSS-ID: 0MGDXVH-02-0OG-02 X-M-MSG: Received: from sausexedgep01.amd.com (sausexedgep01-ext.amd.com [163.181.249.72]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ausb3twp02.amd.com (Axway MailGate 3.8.1) with ESMTP id 26E4BC8082; Wed, 9 Jan 2013 19:09:17 -0600 (CST) Received: from SAUSEXDAG05.amd.com (163.181.55.6) by sausexedgep01.amd.com (163.181.36.54) with Microsoft SMTP Server (TLS) id 8.3.192.1; Wed, 9 Jan 2013 19:09:34 -0600 Received: from Work.amd.com (163.181.55.254) by sausexdag05.amd.com (163.181.55.6) with Microsoft SMTP Server id 14.2.318.4; Wed, 9 Jan 2013 19:09:20 -0600 From: Aravind Gopalakrishnan To: , , , CC: Aravind Gopalakrishnan Subject: [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable. Date: Wed, 9 Jan 2013 19:09:21 -0600 Message-ID: <1357780161-30581-1-git-send-email-Aravind.Gopalakrishnan@amd.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-OriginatorOrg: amd.com Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This patch is in reference to bug#:51741. (https://bugzilla.kernel.org/show_bug.cgi?id=51741) powernow-k8 falls back to acpi-cpufreq if CPU is not supported. However, it states that acpi-cpufreq has taken over even if acpi-cpufreq is not compiled in. This patch rewords the warning message to clarify that the CPU is unsupported and prints a warning message when there is no acpi-cpufreq present. Signed-off-by: Aravind Gopalakrishnan --- drivers/cpufreq/powernow-k8.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index 056faf6..6fa58b4 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1256,7 +1256,15 @@ static int __cpuinit powernowk8_init(void) int rv; if (static_cpu_has(X86_FEATURE_HW_PSTATE)) { - pr_warn(PFX "this CPU is not supported anymore, using acpi-cpufreq instead.\n"); + pr_warn(PFX + "this CPU is not supported anymore, use acpi-cpufreq instead" + "Look for message from acpi-cpufreq to ensure it is loaded." + ".\n"); +#ifndef CONFIG_X86_ACPI_CPUFREQ + pr_warn(PFX "acpi-cpufreq is disabled." + "Enable it in the config options to get frequency scaling.\n"); + return -ENODEV; +#endif request_module("acpi-cpufreq"); return -ENODEV; }