| Message ID | 1362755024.31506.44.camel@cliu38-desktop-build (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Len Brown |
| Headers | show |
On 03/08/2013 04:03 PM, Chuansheng Liu wrote: > > According to commit e022e7eb9, the .enter == NULL is the last one in > state_tables[]. > > So just like intel_idle_cpuidle_driver_init(), in case of .enter == NULL, > breaking the for(;;) loop directly. > > Signed-off-by: liu chuansheng <chuansheng.liu@intel.com> > --- Sounds good. Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> > drivers/idle/intel_idle.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index 5d66750..17c9cf9 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -610,7 +610,7 @@ static int intel_idle_cpu_init(int cpu) > int num_substates, mwait_hint, mwait_cstate, mwait_substate; > > if (cpuidle_state_table[cstate].enter == NULL) > - continue; > + break; > > if (cstate + 1 > max_cstate) { > printk(PREFIX "max_cstate %d reached\n", max_cstate); >
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 5d66750..17c9cf9 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -610,7 +610,7 @@ static int intel_idle_cpu_init(int cpu) int num_substates, mwait_hint, mwait_cstate, mwait_substate; if (cpuidle_state_table[cstate].enter == NULL) - continue; + break; if (cstate + 1 > max_cstate) { printk(PREFIX "max_cstate %d reached\n", max_cstate);
According to commit e022e7eb9, the .enter == NULL is the last one in state_tables[]. So just like intel_idle_cpuidle_driver_init(), in case of .enter == NULL, breaking the for(;;) loop directly. Signed-off-by: liu chuansheng <chuansheng.liu@intel.com> --- drivers/idle/intel_idle.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)