From patchwork Mon Mar 11 15:14:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Silviu-Mihai Popescu X-Patchwork-Id: 2249171 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E0602DF5B1 for ; Mon, 11 Mar 2013 15:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692Ab3CKPOL (ORCPT ); Mon, 11 Mar 2013 11:14:11 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:38395 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665Ab3CKPOK (ORCPT ); Mon, 11 Mar 2013 11:14:10 -0400 Received: by mail-wg0-f48.google.com with SMTP id 16so4918592wgi.15 for ; Mon, 11 Mar 2013 08:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=bp8Ji+PjNBnJ9mD2OLZ2G1V3pgrnqy3z0wMeIBJv2VY=; b=QWri58u5BjNzT5TotNx8bCLUWujHq8VuZHvcT627yM1fmq/5a2vLs7q4o2LytkLdpf S5orf7cvPjeNOMz6+SIGUoPKRTB4ZUZgXvXUqUhmbos3NsEu7yOzD0raqhXVupLRS9D+ s0GZFLaopFzZg88mQuyFgESddPmsKyljz+QfwccEeo3hXk4MmZyN6mZkAfDT6Rvk+pat 7FtuxHCr360dW7R1OCuS0ocHqk3RxpTXwclUVjZ1p35reT3Yaz18s0wZEUq4VB+/gCH/ L1qj0zLEHzqo386ZG5BOFPHyECC7OR7qCq/9ZosxXFWgn+LybiKUinLp3g07l4P7/CK5 SQmA== X-Received: by 10.180.100.10 with SMTP id eu10mr13343905wib.4.1363014847081; Mon, 11 Mar 2013 08:14:07 -0700 (PDT) Received: from localhost.localdomain (p5.eregie.pub.ro. [141.85.0.105]) by mx.google.com with ESMTPS id ed6sm17780048wib.9.2013.03.11.08.14.04 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 11 Mar 2013 08:14:06 -0700 (PDT) From: Silviu-Mihai Popescu To: cpufreq@vger.kernel.org Cc: rjw@sisk.pl, jason@lakedaemon.net, andrew@lunn.ch, daniel.lezcano@linaro.org, len.brown@intel.com, rob.lee@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Silviu-Mihai Popescu Subject: [PATCH v2] kirkwood: fix coccicheck warnings Date: Mon, 11 Mar 2013 17:14:02 +0200 Message-Id: <1363014842-11659-1-git-send-email-silviupopescu1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Silviu-Mihai Popescu Reviewed-by: Daniel Lezcano --- drivers/cpufreq/kirkwood-cpufreq.c | 8 +++----- drivers/cpuidle/cpuidle-kirkwood.c | 6 +++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c index 0e83e3c..6052476 100644 --- a/drivers/cpufreq/kirkwood-cpufreq.c +++ b/drivers/cpufreq/kirkwood-cpufreq.c @@ -175,11 +175,9 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) dev_err(&pdev->dev, "Cannot get memory resource\n"); return -ENODEV; } - priv.base = devm_request_and_ioremap(&pdev->dev, res); - if (!priv.base) { - dev_err(&pdev->dev, "Cannot ioremap\n"); - return -EADDRNOTAVAIL; - } + priv.base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(priv.base)) + return PTR_ERR(priv.base); np = of_find_node_by_path("/cpus/cpu@0"); if (!np) diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c index 670aa1e..53aad73 100644 --- a/drivers/cpuidle/cpuidle-kirkwood.c +++ b/drivers/cpuidle/cpuidle-kirkwood.c @@ -66,9 +66,9 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev) if (res == NULL) return -EINVAL; - ddr_operation_base = devm_request_and_ioremap(&pdev->dev, res); - if (!ddr_operation_base) - return -EADDRNOTAVAIL; + ddr_operation_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(ddr_operation_base)) + return PTR_ERR(ddr_operation_base); device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id()); device->state_count = KIRKWOOD_MAX_STATES;