| Message ID | 1363080476-26555-2-git-send-email-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
On 03/12/2013 10:27 AM, Daniel Lezcano wrote: > When the CPU_IDLE and the ARCH_HIGHBANK options are set it is > pointless to define a new option CPU_IDLE_CALXEDA because it > is redundant. > > The Makefile drivers directory contains a condition to compile > the cpuidle drivers: > > obj-$(CONFIG_CPU_IDLE) += cpuidle/ > > Hence, if CPU_IDLE is not set we won't enter this directory. > > This patch removes the useless Kconfig option and replaces the > condition in the Makefile by CONFIG_ARCH_HIGHBANK. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- Hi Rob, sorry I missed to add you in Cc for this patch. Regards -- Daniel > drivers/cpuidle/Kconfig | 10 ---------- > drivers/cpuidle/Makefile | 2 +- > 2 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig > index c4cc27e..234ae65 100644 > --- a/drivers/cpuidle/Kconfig > +++ b/drivers/cpuidle/Kconfig > @@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU > > config ARCH_NEEDS_CPU_IDLE_COUPLED > def_bool n > - > -if CPU_IDLE > - > -config CPU_IDLE_CALXEDA > - bool "CPU Idle Driver for Calxeda processors" > - depends on ARCH_HIGHBANK > - help > - Select this to enable cpuidle on Calxeda processors. > - > -endif > diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile > index 0d8bd55..d1aba71 100644 > --- a/drivers/cpuidle/Makefile > +++ b/drivers/cpuidle/Makefile > @@ -5,5 +5,5 @@ > obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ > obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o > > -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o > +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o > obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o >
On 03/12/2013 04:27 AM, Daniel Lezcano wrote: > When the CPU_IDLE and the ARCH_HIGHBANK options are set it is > pointless to define a new option CPU_IDLE_CALXEDA because it > is redundant. > > The Makefile drivers directory contains a condition to compile > the cpuidle drivers: > > obj-$(CONFIG_CPU_IDLE) += cpuidle/ > > Hence, if CPU_IDLE is not set we won't enter this directory. > > This patch removes the useless Kconfig option and replaces the > condition in the Makefile by CONFIG_ARCH_HIGHBANK. If I have multiple platforms including highbank compiled in, but want to disable cpuidle just for highbank, then you can't disable it at compile time. Also, with my PSCI support patches for highbank, it is no longer dependent on ARCH_HIGHBANK which gives us better compile test coverage. Rob > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/cpuidle/Kconfig | 10 ---------- > drivers/cpuidle/Makefile | 2 +- > 2 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig > index c4cc27e..234ae65 100644 > --- a/drivers/cpuidle/Kconfig > +++ b/drivers/cpuidle/Kconfig > @@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU > > config ARCH_NEEDS_CPU_IDLE_COUPLED > def_bool n > - > -if CPU_IDLE > - > -config CPU_IDLE_CALXEDA > - bool "CPU Idle Driver for Calxeda processors" > - depends on ARCH_HIGHBANK > - help > - Select this to enable cpuidle on Calxeda processors. > - > -endif > diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile > index 0d8bd55..d1aba71 100644 > --- a/drivers/cpuidle/Makefile > +++ b/drivers/cpuidle/Makefile > @@ -5,5 +5,5 @@ > obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ > obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o > > -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o > +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o > obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/19/2013 01:22 PM, Rob Herring wrote: > On 03/12/2013 04:27 AM, Daniel Lezcano wrote: >> When the CPU_IDLE and the ARCH_HIGHBANK options are set it is >> pointless to define a new option CPU_IDLE_CALXEDA because it >> is redundant. >> >> The Makefile drivers directory contains a condition to compile >> the cpuidle drivers: >> >> obj-$(CONFIG_CPU_IDLE) += cpuidle/ >> >> Hence, if CPU_IDLE is not set we won't enter this directory. >> >> This patch removes the useless Kconfig option and replaces the >> condition in the Makefile by CONFIG_ARCH_HIGHBANK. > > If I have multiple platforms including highbank compiled in, but want to > disable cpuidle just for highbank, then you can't disable it at compile > time. Could you elaborate a bit ? Is it today possible to have multiple platforms in a single kernel ? > Also, with my PSCI support patches for highbank, it is no longer > dependent on ARCH_HIGHBANK which gives us better compile test coverage. >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> drivers/cpuidle/Kconfig | 10 ---------- >> drivers/cpuidle/Makefile | 2 +- >> 2 files changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig >> index c4cc27e..234ae65 100644 >> --- a/drivers/cpuidle/Kconfig >> +++ b/drivers/cpuidle/Kconfig >> @@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU >> >> config ARCH_NEEDS_CPU_IDLE_COUPLED >> def_bool n >> - >> -if CPU_IDLE >> - >> -config CPU_IDLE_CALXEDA >> - bool "CPU Idle Driver for Calxeda processors" >> - depends on ARCH_HIGHBANK >> - help >> - Select this to enable cpuidle on Calxeda processors. >> - >> -endif >> diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile >> index 0d8bd55..d1aba71 100644 >> --- a/drivers/cpuidle/Makefile >> +++ b/drivers/cpuidle/Makefile >> @@ -5,5 +5,5 @@ >> obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ >> obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o >> >> -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o >> +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o >> obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o >> >
On 03/19/2013 09:35 AM, Daniel Lezcano wrote: > On 03/19/2013 01:22 PM, Rob Herring wrote: >> On 03/12/2013 04:27 AM, Daniel Lezcano wrote: >>> When the CPU_IDLE and the ARCH_HIGHBANK options are set it is >>> pointless to define a new option CPU_IDLE_CALXEDA because it >>> is redundant. >>> >>> The Makefile drivers directory contains a condition to compile >>> the cpuidle drivers: >>> >>> obj-$(CONFIG_CPU_IDLE) += cpuidle/ >>> >>> Hence, if CPU_IDLE is not set we won't enter this directory. >>> >>> This patch removes the useless Kconfig option and replaces the >>> condition in the Makefile by CONFIG_ARCH_HIGHBANK. >> >> If I have multiple platforms including highbank compiled in, but want to >> disable cpuidle just for highbank, then you can't disable it at compile >> time. > > Could you elaborate a bit ? Is it today possible to have multiple > platforms in a single kernel ? You've heard of single zImage, right? Vexpress, mvebu, highbank, imx, omap2+, socfpga, vt8500 off the top of my head as of 3.8. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/19/2013 04:13 PM, Rob Herring wrote: > On 03/19/2013 09:35 AM, Daniel Lezcano wrote: >> On 03/19/2013 01:22 PM, Rob Herring wrote: >>> On 03/12/2013 04:27 AM, Daniel Lezcano wrote: >>>> When the CPU_IDLE and the ARCH_HIGHBANK options are set it is >>>> pointless to define a new option CPU_IDLE_CALXEDA because it >>>> is redundant. >>>> >>>> The Makefile drivers directory contains a condition to compile >>>> the cpuidle drivers: >>>> >>>> obj-$(CONFIG_CPU_IDLE) += cpuidle/ >>>> >>>> Hence, if CPU_IDLE is not set we won't enter this directory. >>>> >>>> This patch removes the useless Kconfig option and replaces the >>>> condition in the Makefile by CONFIG_ARCH_HIGHBANK. >>> >>> If I have multiple platforms including highbank compiled in, but want to >>> disable cpuidle just for highbank, then you can't disable it at compile >>> time. >> >> Could you elaborate a bit ? Is it today possible to have multiple >> platforms in a single kernel ? > > You've heard of single zImage, right? Vexpress, mvebu, highbank, imx, > omap2+, socfpga, vt8500 off the top of my head as of 3.8. Yes, I have heard of single zImage but I am not aware of the status. IIUC, the approach would be the same as cpufreq, right ? I am not sure the cpuidle drivers are ready for that. We can keep the current Makefile but I am in favor of removing this Kconfig option for now, unify as much as possible all the drivers, create a common driver for all and then address the single zImage for all these drivers at the same time.
diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig index c4cc27e..234ae65 100644 --- a/drivers/cpuidle/Kconfig +++ b/drivers/cpuidle/Kconfig @@ -30,13 +30,3 @@ config CPU_IDLE_GOV_MENU config ARCH_NEEDS_CPU_IDLE_COUPLED def_bool n - -if CPU_IDLE - -config CPU_IDLE_CALXEDA - bool "CPU Idle Driver for Calxeda processors" - depends on ARCH_HIGHBANK - help - Select this to enable cpuidle on Calxeda processors. - -endif diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index 0d8bd55..d1aba71 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -5,5 +5,5 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o +obj-$(CONFIG_ARCH_HIGHBANK) += cpuidle-calxeda.o obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
When the CPU_IDLE and the ARCH_HIGHBANK options are set it is pointless to define a new option CPU_IDLE_CALXEDA because it is redundant. The Makefile drivers directory contains a condition to compile the cpuidle drivers: obj-$(CONFIG_CPU_IDLE) += cpuidle/ Hence, if CPU_IDLE is not set we won't enter this directory. This patch removes the useless Kconfig option and replaces the condition in the Makefile by CONFIG_ARCH_HIGHBANK. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/cpuidle/Kconfig | 10 ---------- drivers/cpuidle/Makefile | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)