From patchwork Fri Mar 22 00:10:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Silviu-Mihai Popescu X-Patchwork-Id: 2317681 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 12D1040213 for ; Fri, 22 Mar 2013 00:10:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753788Ab3CVAKa (ORCPT ); Thu, 21 Mar 2013 20:10:30 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:44150 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654Ab3CVAKa (ORCPT ); Thu, 21 Mar 2013 20:10:30 -0400 Received: by mail-ee0-f53.google.com with SMTP id e53so1951532eek.26 for ; Thu, 21 Mar 2013 17:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=NMjJXU6ekn15Yt4DihDgiyQNhijnKxt2E4M9gGKW07o=; b=0QyGTyHy4U16QsAA4IfQNHww6lGwcRIHqBKuwRhvVlsSMOe8GoCY9J1iE7qCCdTuqJ d2b2ylWaQBLaQZAYHgBwGg0gzIACpqaVVMweUaQ9Tdoc5nZ3DG0Is2TLrFpgE+gIKzXA pJQ3QSrE87/VJEo2wLhTRoeQE9cY/b/fLbKi/ZDt5a4aFA6vP45vVLKbDX7DAeXlOVlJ v+OJ/BCj5WVKw6ovp7b0IJRgbN46DG8KOQ79y35A2RVKuPyByi7xXZAjIaH6he0/lGfv NthR5FWGjZsoGk8s8Lm73nVFxREBqDyS9ywtBnSwujTwFubYt/3VP9AstKkGk87LyRBz J+vw== X-Received: by 10.14.225.72 with SMTP id y48mr87862899eep.45.1363911028596; Thu, 21 Mar 2013 17:10:28 -0700 (PDT) Received: from localhost.localdomain (p5.eregie.pub.ro. [141.85.0.105]) by mx.google.com with ESMTPS id q5sm62406eep.11.2013.03.21.17.10.25 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Mar 2013 17:10:27 -0700 (PDT) From: Silviu-Mihai Popescu To: cpufreq@vger.kernel.org Cc: rjw@sisk.pl, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Silviu-Mihai Popescu Subject: [PATCH] drivers: cpufreq: kirkwood: fix coccicheck warnings Date: Fri, 22 Mar 2013 02:10:22 +0200 Message-Id: <1363911022-7786-1-git-send-email-silviupopescu1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Silviu-Mihai Popescu Acked-by: Viresh Kumar --- drivers/cpufreq/kirkwood-cpufreq.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c index 0e83e3c..6052476 100644 --- a/drivers/cpufreq/kirkwood-cpufreq.c +++ b/drivers/cpufreq/kirkwood-cpufreq.c @@ -175,11 +175,9 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) dev_err(&pdev->dev, "Cannot get memory resource\n"); return -ENODEV; } - priv.base = devm_request_and_ioremap(&pdev->dev, res); - if (!priv.base) { - dev_err(&pdev->dev, "Cannot ioremap\n"); - return -EADDRNOTAVAIL; - } + priv.base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(priv.base)) + return PTR_ERR(priv.base); np = of_find_node_by_path("/cpus/cpu@0"); if (!np)