| Message ID | 1366218743-20841-27-git-send-email-eduardo.valentin@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
> -----Original Message----- > From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kachhap@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols > Importance: High > > The list is needed so far. Thus removing it. > s/needed/not needed? Thanks, rui > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/thermal/cpu_cooling.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/thermal/cpu_cooling.c > b/drivers/thermal/cpu_cooling.c index 3709274..825231f 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -38,11 +38,9 @@ > * @cpufreq_val: integer value representing the absolute value of the > clipped > * frequency. > * @allowed_cpus: all the cpus involved for this > cpufreq_cooling_device. > - * @node: list_head to link all cpufreq_cooling_device together. > * > * This structure is required for keeping information of each > - * cpufreq_cooling_device registered as a list whose head is > represented by > - * cooling_cpufreq_list. In order to prevent corruption of this list a > + * cpufreq_cooling_device registered. In order to prevent corruption > of > + this a > * mutex lock cooling_cpufreq_lock is used. > */ > struct cpufreq_cooling_device { > @@ -51,9 +49,7 @@ struct cpufreq_cooling_device { > unsigned int cpufreq_state; > unsigned int cpufreq_val; > struct cpumask allowed_cpus; > - struct list_head node; > }; > -static LIST_HEAD(cooling_cpufreq_list); static > DEFINE_IDR(cpufreq_idr); static DEFINE_MUTEX(cooling_cpufreq_lock); > > -- > 1.8.2.1.342.gfa7285d -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24-04-2013 10:52, Zhang, Rui wrote: > > >> -----Original Message----- >> From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] >> Sent: Thursday, April 18, 2013 1:12 AM >> To: amit.kachhap@linaro.org >> Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols >> Importance: High >> >> The list is needed so far. Thus removing it. >> > s/needed/not needed? > yes, thanks. > Thanks, > rui >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: linux-pm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >> --- >> drivers/thermal/cpu_cooling.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/thermal/cpu_cooling.c >> b/drivers/thermal/cpu_cooling.c index 3709274..825231f 100644 >> --- a/drivers/thermal/cpu_cooling.c >> +++ b/drivers/thermal/cpu_cooling.c >> @@ -38,11 +38,9 @@ >> * @cpufreq_val: integer value representing the absolute value of the >> clipped >> * frequency. >> * @allowed_cpus: all the cpus involved for this >> cpufreq_cooling_device. >> - * @node: list_head to link all cpufreq_cooling_device together. >> * >> * This structure is required for keeping information of each >> - * cpufreq_cooling_device registered as a list whose head is >> represented by >> - * cooling_cpufreq_list. In order to prevent corruption of this list a >> + * cpufreq_cooling_device registered. In order to prevent corruption >> of >> + this a >> * mutex lock cooling_cpufreq_lock is used. >> */ >> struct cpufreq_cooling_device { >> @@ -51,9 +49,7 @@ struct cpufreq_cooling_device { >> unsigned int cpufreq_state; >> unsigned int cpufreq_val; >> struct cpumask allowed_cpus; >> - struct list_head node; >> }; >> -static LIST_HEAD(cooling_cpufreq_list); static >> DEFINE_IDR(cpufreq_idr); static DEFINE_MUTEX(cooling_cpufreq_lock); >> >> -- >> 1.8.2.1.342.gfa7285d > > > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 3709274..825231f 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -38,11 +38,9 @@ * @cpufreq_val: integer value representing the absolute value of the clipped * frequency. * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device. - * @node: list_head to link all cpufreq_cooling_device together. * * This structure is required for keeping information of each - * cpufreq_cooling_device registered as a list whose head is represented by - * cooling_cpufreq_list. In order to prevent corruption of this list a + * cpufreq_cooling_device registered. In order to prevent corruption of this a * mutex lock cooling_cpufreq_lock is used. */ struct cpufreq_cooling_device { @@ -51,9 +49,7 @@ struct cpufreq_cooling_device { unsigned int cpufreq_state; unsigned int cpufreq_val; struct cpumask allowed_cpus; - struct list_head node; }; -static LIST_HEAD(cooling_cpufreq_list); static DEFINE_IDR(cpufreq_idr); static DEFINE_MUTEX(cooling_cpufreq_lock);
The list is needed so far. Thus removing it. Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- drivers/thermal/cpu_cooling.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)