| Message ID | 1366218743-20841-3-git-send-email-eduardo.valentin@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
> -----Original Message----- > From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kachhap@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 02/30] thermal: cpu_cooling: remove trailing white > spaces > Importance: High > > Remove unnecessary white spaces. > The same comments for patch 02, 06, 09, 10, 11, 13, 18, and 30. Can we run Lindent to fix all the coding style problem in one patch? Thanks, rui > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/thermal/cpu_cooling.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/thermal/cpu_cooling.c > b/drivers/thermal/cpu_cooling.c index 778c43d..d0d6a0c 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -131,14 +131,13 @@ static int get_property(unsigned int cpu, > unsigned long input, > int descend = -1; > struct cpufreq_frequency_table *table = > cpufreq_frequency_get_table(cpu); > - > + > if (!output) > return -EINVAL; > > if (!table) > return -EINVAL; > > - > for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) { > /* ignore invalid entries */ > if (table[i].frequency == CPUFREQ_ENTRY_INVALID) > -- > 1.8.2.1.342.gfa7285d -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Zhang, Rui > Sent: Wednesday, April 24, 2013 10:49 PM > To: Eduardo Valentin; amit.kachhap@linaro.org > Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 02/30] thermal: cpu_cooling: remove trailing white > spaces > > > > > -----Original Message----- > > From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] > > Sent: Thursday, April 18, 2013 1:12 AM > > To: amit.kachhap@linaro.org > > Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: [PATCH 02/30] thermal: cpu_cooling: remove trailing white > > spaces > > Importance: High > > > > Remove unnecessary white spaces. > > > The same comments for patch 02, 06, 09, 10, 11, 13, 18, and 30. > All the other patches applied. Thanks, rui > Can we run Lindent to fix all the coding style problem in one patch? > > Thanks, > rui > > Cc: Zhang Rui <rui.zhang@intel.com> > > Cc: linux-pm@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > > --- > > drivers/thermal/cpu_cooling.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/thermal/cpu_cooling.c > > b/drivers/thermal/cpu_cooling.c index 778c43d..d0d6a0c 100644 > > --- a/drivers/thermal/cpu_cooling.c > > +++ b/drivers/thermal/cpu_cooling.c > > @@ -131,14 +131,13 @@ static int get_property(unsigned int cpu, > > unsigned long input, > > int descend = -1; > > struct cpufreq_frequency_table *table = > > cpufreq_frequency_get_table(cpu); > > - > > + > > if (!output) > > return -EINVAL; > > > > if (!table) > > return -EINVAL; > > > > - > > for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) { > > /* ignore invalid entries */ > > if (table[i].frequency == CPUFREQ_ENTRY_INVALID) > > -- > > 1.8.2.1.342.gfa7285d > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org More majordomo info > at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24-04-2013 10:48, Zhang, Rui wrote: > > >> -----Original Message----- >> From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] >> Sent: Thursday, April 18, 2013 1:12 AM >> To: amit.kachhap@linaro.org >> Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: [PATCH 02/30] thermal: cpu_cooling: remove trailing white >> spaces >> Importance: High >> >> Remove unnecessary white spaces. >> > The same comments for patch 02, 06, 09, 10, 11, 13, 18, and 30. > > Can we run Lindent to fix all the coding style problem in one patch? Well, yes. The thing about Lindent is that it sometimes changes the code in a way we do not want. It will change cpu-cooling in slightly different way, but it will include most of the changes on the patches above. It misses some of the changes and also does some other that are not so nice. I obviously would prefer to keep these patches, as, the patches are already there. Let me know what is your call. > > Thanks, > rui >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: linux-pm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >> --- >> drivers/thermal/cpu_cooling.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/cpu_cooling.c >> b/drivers/thermal/cpu_cooling.c index 778c43d..d0d6a0c 100644 >> --- a/drivers/thermal/cpu_cooling.c >> +++ b/drivers/thermal/cpu_cooling.c >> @@ -131,14 +131,13 @@ static int get_property(unsigned int cpu, >> unsigned long input, >> int descend = -1; >> struct cpufreq_frequency_table *table = >> cpufreq_frequency_get_table(cpu); >> - >> + >> if (!output) >> return -EINVAL; >> >> if (!table) >> return -EINVAL; >> >> - >> for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) { >> /* ignore invalid entries */ >> if (table[i].frequency == CPUFREQ_ENTRY_INVALID) >> -- >> 1.8.2.1.342.gfa7285d > > > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 778c43d..d0d6a0c 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -131,14 +131,13 @@ static int get_property(unsigned int cpu, unsigned long input, int descend = -1; struct cpufreq_frequency_table *table = cpufreq_frequency_get_table(cpu); - + if (!output) return -EINVAL; if (!table) return -EINVAL; - for (i = 0; table[i].frequency != CPUFREQ_TABLE_END; i++) { /* ignore invalid entries */ if (table[i].frequency == CPUFREQ_ENTRY_INVALID)
Remove unnecessary white spaces. Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- drivers/thermal/cpu_cooling.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)