| Message ID | 1369863420-21913-1-git-send-email-eduardo.valentin@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
On Wed, 2013-05-29 at 17:37 -0400, Eduardo Valentin wrote: > In case emulated temperature is in use, using the trend > provided by driver layer can lead to bogus situation. > In this case, debugger user would set a temperature value, > but the trend would be from driver computation. > > To avoid this situation, this patch changes the get_tz_trend() > to consider the emulated temperature whenever that is in use. > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Amit Daniel Kachhap <amit.daniel@samsung.com> > Cc: Durgadoss R <durgadoss.r@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> patch applied. thanks, rui > --- > drivers/thermal/thermal_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index d755440..c00dc92 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -155,7 +155,8 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip) > { > enum thermal_trend trend; > > - if (!tz->ops->get_trend || tz->ops->get_trend(tz, trip, &trend)) { > + if (tz->emul_temperature || !tz->ops->get_trend || > + tz->ops->get_trend(tz, trip, &trend)) { > if (tz->temperature > tz->last_temperature) > trend = THERMAL_TREND_RAISING; > else if (tz->temperature < tz->last_temperature) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Eduardo Valentin > Sent: Thursday, May 30, 2013 3:07 AM > To: Zhang, Rui > Cc: Eduardo Valentin; Amit Daniel Kachhap; R, Durgadoss; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH 1/1] thermal: consider emul_temperature while computing > trend > > In case emulated temperature is in use, using the trend > provided by driver layer can lead to bogus situation. > In this case, debugger user would set a temperature value, > but the trend would be from driver computation. > > To avoid this situation, this patch changes the get_tz_trend() > to consider the emulated temperature whenever that is in use. Nice catch. Sorry, I missed looking at it earlier. Just got woken up by Rui's reply on this. The patch looks fine to me. Thanks, Durga > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Amit Daniel Kachhap <amit.daniel@samsung.com> > Cc: Durgadoss R <durgadoss.r@intel.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/thermal/thermal_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c > b/drivers/thermal/thermal_core.c > index d755440..c00dc92 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -155,7 +155,8 @@ int get_tz_trend(struct thermal_zone_device *tz, int > trip) > { > enum thermal_trend trend; > > - if (!tz->ops->get_trend || tz->ops->get_trend(tz, trip, &trend)) { > + if (tz->emul_temperature || !tz->ops->get_trend || > + tz->ops->get_trend(tz, trip, &trend)) { > if (tz->temperature > tz->last_temperature) > trend = THERMAL_TREND_RAISING; > else if (tz->temperature < tz->last_temperature) > -- > 1.8.2.1.342.gfa7285d > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index d755440..c00dc92 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -155,7 +155,8 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip) { enum thermal_trend trend; - if (!tz->ops->get_trend || tz->ops->get_trend(tz, trip, &trend)) { + if (tz->emul_temperature || !tz->ops->get_trend || + tz->ops->get_trend(tz, trip, &trend)) { if (tz->temperature > tz->last_temperature) trend = THERMAL_TREND_RAISING; else if (tz->temperature < tz->last_temperature)
In case emulated temperature is in use, using the trend provided by driver layer can lead to bogus situation. In this case, debugger user would set a temperature value, but the trend would be from driver computation. To avoid this situation, this patch changes the get_tz_trend() to consider the emulated temperature whenever that is in use. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Amit Daniel Kachhap <amit.daniel@samsung.com> Cc: Durgadoss R <durgadoss.r@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- drivers/thermal/thermal_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)