From patchwork Mon Jun 17 13:24:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 2733411 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6D818C0AB1 for ; Mon, 17 Jun 2013 13:25:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E40E320343 for ; Mon, 17 Jun 2013 13:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB242202B3 for ; Mon, 17 Jun 2013 13:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932357Ab3FQNZA (ORCPT ); Mon, 17 Jun 2013 09:25:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:50832 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529Ab3FQNY7 (ORCPT ); Mon, 17 Jun 2013 09:24:59 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 17 Jun 2013 06:25:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,881,1363158000"; d="scan'208";a="354717492" Received: from unknown (HELO rzhang1-mobl4.ccr.corp.intel.com) ([10.255.20.69]) by fmsmga002.fm.intel.com with ESMTP; 17 Jun 2013 06:24:54 -0700 From: Zhang Rui To: linux-pm@vger.kernel.org Cc: eduardo.valentin@ti.com, durgadoss.r@intel.com, shawn.guo@linaro.org, ruslan.ruslichenko@ti.com, Zhang Rui Subject: [RFC PATCH 5/6] Thermal: step_wise handle THERMAL_TREND_STABLE explicitly Date: Mon, 17 Jun 2013 21:24:27 +0800 Message-Id: <1371475468-5351-6-git-send-email-rui.zhang@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1371475468-5351-1-git-send-email-rui.zhang@intel.com> References: <1371475468-5351-1-git-send-email-rui.zhang@intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The current code does not show the handling of THERMAL_TREND_STABLE explicitly, which may be confusing. Signed-off-by: Zhang Rui --- drivers/thermal/step_wise.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index 84d6e90..53b56e6 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c @@ -36,6 +36,7 @@ * for this trip point * d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit * for this trip point + * e. if the trend is THERMAL_TREND_STABLE, do nothing. * If the temperature is lower than a trip point, * a. if the trend is THERMAL_TREND_RAISING, do nothing * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling @@ -44,6 +45,7 @@ * c. if the trend is THERMAL_TREND_RAISE_FULL, do nothing * d. if the trend is THERMAL_TREND_DROP_FULL, deactive * the thermal instance + * e. if the trend is THERMAL_TREND_STABLE, do nothing. */ static unsigned long get_target_state(struct thermal_instance *instance, enum thermal_trend trend, bool throttle) @@ -95,6 +97,8 @@ static unsigned long get_target_state(struct thermal_instance *instance, else next_target = THERMAL_NO_TARGET; break; + case THERMAL_TREND_STABLE: + /* Do nothing */ default: break; }