From patchwork Wed Jul 17 15:02:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 2828751 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 31BEBC0AB2 for ; Wed, 17 Jul 2013 15:09:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DB030202C4 for ; Wed, 17 Jul 2013 15:09:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9BEE202E9 for ; Wed, 17 Jul 2013 15:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132Ab3GQPIo (ORCPT ); Wed, 17 Jul 2013 11:08:44 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:33599 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138Ab3GQPE7 (ORCPT ); Wed, 17 Jul 2013 11:04:59 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r6HF3wOt023294; Wed, 17 Jul 2013 10:03:58 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r6HF3wZh022450; Wed, 17 Jul 2013 10:03:58 -0500 Received: from dlelxv24.itg.ti.com (172.17.1.199) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Wed, 17 Jul 2013 10:03:58 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id r6HF3w8d001928; Wed, 17 Jul 2013 10:03:58 -0500 Received: from localhost (h68-2.vpn.ti.com [172.24.68.2]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id r6HF3qt28079; Wed, 17 Jul 2013 10:03:52 -0500 (CDT) From: Eduardo Valentin To: CC: , , , , , Eduardo Valentin , "Rafael J. Wysocki" , Viresh Kumar , Grant Likely , Rob Herring , Subject: [PATCH 3/8] cpufreq: cpufreq-cpu0: add dt node parsing on cooling need Date: Wed, 17 Jul 2013 11:02:42 -0400 Message-ID: <1374073374-30946-7-git-send-email-eduardo.valentin@ti.com> X-Mailer: git-send-email 1.8.2.1.342.gfa7285d In-Reply-To: <1374073374-30946-1-git-send-email-eduardo.valentin@ti.com> References: <1374073374-30946-1-git-send-email-eduardo.valentin@ti.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch changes the cpufreq-cpu0 driver to consider if a cpu needs cooling (with cpufreq). In case the cooling is needed, it can be flagged at the cpu0 device tree node, with the boolean property 'needs-cooling'. In case this boolean is present, the driver will load a cpufreq cooling device in the system. The cpufreq-cpu0 driver is not capable of determining how the system should be using the cooling device. This can be described using device tree, to determine what needs to be done with the loaded cpufreq cooling device, in case the system temperature is detected to be high, with help of temperature sensors (check Documentation/devicetree/bindings/thermal/thermal.txt). Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Grant Likely Cc: Rob Herring Cc: cpufreq@vger.kernel.org Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org Signed-off-by: Eduardo Valentin --- .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 3 ++ .../devicetree/bindings/thermal/thermal.txt | 34 ++++++++++++++++++++++ drivers/cpufreq/cpufreq-cpu0.c | 8 +++++ 3 files changed, 45 insertions(+) diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt index 051f764..e8ff916 100644 --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt @@ -15,6 +15,8 @@ Optional properties: - clock-latency: Specify the possible maximum transition latency for clock, in unit of nanoseconds. - voltage-tolerance: Specify the CPU voltage tolerance in percentage. +- needs-cooling: The generic cpu cooling (freq clipping) is loaded by the +generic cpufreq-cpu0 driver in case the device tree node has this boolean. Examples: @@ -33,6 +35,7 @@ cpus { 198000 850000 >; clock-latency = <61036>; /* two CLK32 periods */ + needs-cooling; }; cpu@1 { diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index 03751bb..ac0c7b9 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -97,3 +97,37 @@ thermal_zone { }; }; }; + +*************** +cpufreq-cooling +*************** + +The generic cpu cooling (freq clipping) can be loaded by the +generic cpufreq-cpu0 driver in case the device tree node informs +this need. + +In order to load the cpufreq cooling device, it is possible to +inform that the cpu needs cooling by adding the boolean flag +'needs-cooling' at the cpu0 phandle. + +Example: + cpus { + cpu@0 { + operating-points = < + /* kHz uV */ + 800000 1313000 + 1008000 1375000 + >; + needs-cooling; /* make sure we have cpufreq-cooling */ + }; + ... + }; + +The above will cause the cpufreq-cpu0 driver to understand that +the cpu will need passive cooling and while probing that node it will +also load the cpufreq cpu cooling device in that system. + +However, be advised that this flag will not describe what needs to +be done or how the cpufreq cooling device will be used. In order to +accomplish this, one needs to write a phandle for a thermal zone, as +described in the section 'thermal_zone'. diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index ad1fde2..4a8747a 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -20,6 +20,9 @@ #include #include #include +#include +#include +#include static unsigned int transition_latency; static unsigned int voltage_tolerance; /* in percentage */ @@ -28,6 +31,7 @@ static struct device *cpu_dev; static struct clk *cpu_clk; static struct regulator *cpu_reg; static struct cpufreq_frequency_table *freq_table; +static struct thermal_cooling_device *cdev; static int cpu0_verify_speed(struct cpufreq_policy *policy) { @@ -268,6 +272,9 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) goto out_free_table; } + if (of_property_read_bool(np, "needs-cooling")) + cdev = cpufreq_cooling_register(cpu_present_mask); + of_node_put(np); of_node_put(parent); return 0; @@ -283,6 +290,7 @@ out_put_parent: static int cpu0_cpufreq_remove(struct platform_device *pdev) { + cpufreq_cooling_unregister(cdev); cpufreq_unregister_driver(&cpu0_cpufreq_driver); opp_free_cpufreq_table(cpu_dev, &freq_table);