| Message ID | 1374543541-4451-1-git-send-email-tangchen@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Reviewed-by: Len Brown <len.brown@intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
* Tang Chen <tangchen@cn.fujitsu.com> wrote: > We wanted to check if the acpi id is out of range. It should be: > if (id >= (MAX_LOCAL_APIC)). Does this have any practical impact, or can it wait until v3.12? > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > --- > arch/x86/kernel/acpi/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > index d81a972..2a15ae7 100644 > --- a/arch/x86/kernel/acpi/boot.c > +++ b/arch/x86/kernel/acpi/boot.c > @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled) > { > unsigned int ver = 0; > > - if (id >= (MAX_LOCAL_APIC-1)) { > + if (id >= (MAX_LOCAL_APIC)) { The parentheses are now superfluous. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/23/2013 03:39 PM, Ingo Molnar wrote: > > * Tang Chen<tangchen@cn.fujitsu.com> wrote: > >> We wanted to check if the acpi id is out of range. It should be: >> if (id>= (MAX_LOCAL_APIC)). > > Does this have any practical impact, or can it wait until v3.12? I haven't tested out any impact now, just found it when reading the code. We can wait until v3.12. > >> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com> >> --- >> arch/x86/kernel/acpi/boot.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c >> index d81a972..2a15ae7 100644 >> --- a/arch/x86/kernel/acpi/boot.c >> +++ b/arch/x86/kernel/acpi/boot.c >> @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled) >> { >> unsigned int ver = 0; >> >> - if (id>= (MAX_LOCAL_APIC-1)) { >> + if (id>= (MAX_LOCAL_APIC)) { > > The parentheses are now superfluous. Oh, yes. I'll send a new version without the parentheses. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index d81a972..2a15ae7 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled) { unsigned int ver = 0; - if (id >= (MAX_LOCAL_APIC-1)) { + if (id >= (MAX_LOCAL_APIC)) { printk(KERN_INFO PREFIX "skipped apicid that is too big\n"); return; }
We wanted to check if the acpi id is out of range. It should be: if (id >= (MAX_LOCAL_APIC)). Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> --- arch/x86/kernel/acpi/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)