From patchwork Tue Dec 17 17:42:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dirk.brandewie@gmail.com X-Patchwork-Id: 3363061 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 48CFB9F384 for ; Tue, 17 Dec 2013 17:42:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2B03320364 for ; Tue, 17 Dec 2013 17:42:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CB51203A3 for ; Tue, 17 Dec 2013 17:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754965Ab3LQRmT (ORCPT ); Tue, 17 Dec 2013 12:42:19 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:39675 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912Ab3LQRmT (ORCPT ); Tue, 17 Dec 2013 12:42:19 -0500 Received: by mail-pd0-f177.google.com with SMTP id q10so7055655pdj.36 for ; Tue, 17 Dec 2013 09:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XDK+9v3A6n7WgziK2nXC4TknSvUO4pMJGqUUlViyN7Y=; b=zKQY6cCWpFFgRI7QWsghSzGer/iFIYseilfhWJ954ukLdil3Rd0KQCH9YmthTd7UOB 66aLMOdceFMCy/OFaITElW664HZwi2p5qqSLNzlPZ9miLLyduR0AGCnu2FFj4PhB6sHt kG+yfHD0xX42xxYt8XCG94BoNnvvl0DYnPrjXk7GLH9L/ERz3jNcxQFk7rNsoLqVubkJ gYV5sRyv63MSPSmtZBenE+RxMAyeORk7VR4L5fsn0z8MzKnIxCzZK3u5kxQazDD5ld4c tYUotSkrnZLr6oERspo/rsK8kpycnLIwl96ckgtkG4o61ebiG1jRfjwend4qg1s7hws3 6H3Q== X-Received: by 10.68.189.133 with SMTP id gi5mr28900050pbc.57.1387302138847; Tue, 17 Dec 2013 09:42:18 -0800 (PST) Received: from echolake.localdomain (static-50-43-35-129.bvtn.or.frontiernet.net. [50.43.35.129]) by mx.google.com with ESMTPSA id ka3sm35327715pbc.32.2013.12.17.09.42.17 for (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2013 09:42:17 -0800 (PST) From: dirk.brandewie@gmail.com To: linux-pm@vger.kernel.org Cc: rjw@rjwysocki.net, Dirk Brandewie Subject: [PATCH 2/2] intel_pstate: Remove periodic P state boost Date: Tue, 17 Dec 2013 09:42:07 -0800 Message-Id: <1387302127-7614-2-git-send-email-dirk.j.brandewie@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1387302127-7614-1-git-send-email-dirk.j.brandewie@intel.com> References: <1387302127-7614-1-git-send-email-dirk.j.brandewie@intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dirk Brandewie Remove the periodic P state boost. This code required for some corner case benchmark tests. The calculation of the required P state was incorrect/inaccurate and would not allow P state increase. This was fixed by a combination of commits: 2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state d253d2a intel_pstate: Improve accuracy by not truncating until final result Fixes Bug: https://bugzilla.kernel.org/show_bug.cgi?id=64271 Reported-by: Doug Smythies Signed-off-by: Dirk Brandewie --- drivers/cpufreq/intel_pstate.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 4cc4534..5bafccc 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -92,8 +92,6 @@ struct cpudata { struct vid_data vid; struct _pid pid; - int min_pstate_count; - u64 prev_aperf; u64 prev_mperf; int sample_ptr; @@ -617,15 +615,6 @@ static void intel_pstate_timer_func(unsigned long __data) intel_pstate_sample(cpu); intel_pstate_adjust_busy_pstate(cpu); - - if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) { - cpu->min_pstate_count++; - if (!(cpu->min_pstate_count % 5)) { - intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate); - } - } else - cpu->min_pstate_count = 0; - intel_pstate_set_sample_time(cpu); }