| Message ID | 1390061684.5566.4.camel@marge.simpson.net (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote: > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote: >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote: > Signed-off-by: Mike Galbraith <bitbucket@online.de> > Cc: <stable@vger.kernel.org> # 3.10+ > --- > arch/x86/kernel/process.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con Hi, this series of patches never seem to have made it as far as the mainline kernel, anyone know what needs to happen next?
On Sat, 2015-03-14 at 23:44 +0000, Ian Malone wrote: > On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote: > > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote: > >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote: > > > Signed-off-by: Mike Galbraith <bitbucket@online.de> > > Cc: <stable@vger.kernel.org> # 3.10+ > > --- > > arch/x86/kernel/process.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > --- a/arch/x86/kernel/process.c > > +++ b/arch/x86/kernel/process.c > > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con > > Hi, this series of patches never seem to have made it as far as the > mainline kernel, anyone know what needs to happen next? My plan is to keep on carrying it locally for as long as I run new kernels on crusty ole core2 boxen, then stop caring about them entirely like the rest of the planet :) -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15 March 2015 at 04:53, Mike Galbraith <umgwanakikbuti@gmail.com> wrote: > On Sat, 2015-03-14 at 23:44 +0000, Ian Malone wrote: >> On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote: >> > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote: >> >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote: >> >> > Signed-off-by: Mike Galbraith <bitbucket@online.de> >> > Cc: <stable@vger.kernel.org> # 3.10+ >> > --- >> > arch/x86/kernel/process.c | 9 ++++++--- >> > 1 file changed, 6 insertions(+), 3 deletions(-) >> > >> > --- a/arch/x86/kernel/process.c >> > +++ b/arch/x86/kernel/process.c >> > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con >> >> Hi, this series of patches never seem to have made it as far as the >> mainline kernel, anyone know what needs to happen next? > > My plan is to keep on carrying it locally for as long as I run new > kernels on crusty ole core2 boxen, then stop caring about them entirely > like the rest of the planet :) > Looks like Ingo Molnar has committed to tip which is probably a good sign, thanks all. (Have to hand this system on to someone who wont be patching kernels...)
* Ian Malone <ibmalone@gmail.com> wrote: > On 15 March 2015 at 04:53, Mike Galbraith <umgwanakikbuti@gmail.com> wrote: > > On Sat, 2015-03-14 at 23:44 +0000, Ian Malone wrote: > >> On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote: > >> > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote: > >> >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote: > >> > >> > Signed-off-by: Mike Galbraith <bitbucket@online.de> > >> > Cc: <stable@vger.kernel.org> # 3.10+ > >> > --- > >> > arch/x86/kernel/process.c | 9 ++++++--- > >> > 1 file changed, 6 insertions(+), 3 deletions(-) > >> > > >> > --- a/arch/x86/kernel/process.c > >> > +++ b/arch/x86/kernel/process.c > >> > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con > >> > >> Hi, this series of patches never seem to have made it as far as the > >> mainline kernel, anyone know what needs to happen next? > > > > My plan is to keep on carrying it locally for as long as I run new > > kernels on crusty ole core2 boxen, then stop caring about them entirely > > like the rest of the planet :) > > > > Looks like Ingo Molnar has committed to tip which is probably a good > sign, thanks all. > (Have to hand this system on to someone who wont be patching kernels...) Guys, since I don't have the affected hardware, mind testing the latest sched/core tree: git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cd tip git checkout sched/core # build a test kernel and boot it Or if you already have a kernel git tree, do something like this to pick up the scheduler development tree: cd linux.git git remote add git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tip git remote update git checkout tip/sched/core # build a test kernel and boot it and check whether the mwait related bugs are now fixed for good? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2015-03-17 at 09:22 +0100, Ingo Molnar wrote: > * Ian Malone <ibmalone@gmail.com> wrote: > > > On 15 March 2015 at 04:53, Mike Galbraith <umgwanakikbuti@gmail.com> wrote: > > > On Sat, 2015-03-14 at 23:44 +0000, Ian Malone wrote: > > >> On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote: > > >> > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote: > > >> >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote: > > >> > > >> > Signed-off-by: Mike Galbraith <bitbucket@online.de> > > >> > Cc: <stable@vger.kernel.org> # 3.10+ > > >> > --- > > >> > arch/x86/kernel/process.c | 9 ++++++--- > > >> > 1 file changed, 6 insertions(+), 3 deletions(-) > > >> > > > >> > --- a/arch/x86/kernel/process.c > > >> > +++ b/arch/x86/kernel/process.c > > >> > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con > > >> > > >> Hi, this series of patches never seem to have made it as far as the > > >> mainline kernel, anyone know what needs to happen next? > > > > > > My plan is to keep on carrying it locally for as long as I run new > > > kernels on crusty ole core2 boxen, then stop caring about them entirely > > > like the rest of the planet :) > > > > > > > Looks like Ingo Molnar has committed to tip which is probably a good > > sign, thanks all. > > (Have to hand this system on to someone who wont be patching kernels...) > > Guys, since I don't have the affected hardware, mind testing the > latest sched/core tree: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > cd tip > git checkout sched/core > # build a test kernel and boot it > > Or if you already have a kernel git tree, do something like this to > pick up the scheduler development tree: > > cd linux.git > git remote add git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tip > git remote update > git checkout tip/sched/core > # build a test kernel and boot it > > and check whether the mwait related bugs are now fixed for good? "marge" (Q6600 box) is mostly retired now, but I'll kick her out of her rocking chair as soon as I can escape from bugzilla. All should be well, as she's been running it for ages, and ran it in master just a couple days ago. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 17 March 2015 at 08:22, Ingo Molnar <mingo@kernel.org> wrote: > > * Ian Malone <ibmalone@gmail.com> wrote: > >> Looks like Ingo Molnar has committed to tip which is probably a good >> sign, thanks all. >> (Have to hand this system on to someone who wont be patching kernels...) > > Guys, since I don't have the affected hardware, mind testing the > latest sched/core tree: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > cd tip > git checkout sched/core > # build a test kernel and boot it > > Or if you already have a kernel git tree, do something like this to > pick up the scheduler development tree: > > cd linux.git > git remote add git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tip > git remote update > git checkout tip/sched/core > # build a test kernel and boot it > > and check whether the mwait related bugs are now fixed for good? > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=60770, thank you.
--- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con static void mwait_idle(void) { - if (!need_resched()) { - if (this_cpu_has(X86_FEATURE_CLFLUSH_MONITOR)) + if (!current_set_polling_and_test()) { + if (this_cpu_has(X86_FEATURE_CLFLUSH_MONITOR)) { + mb(); clflush((void *)¤t_thread_info()->flags); + mb(); + } __monitor((void *)¤t_thread_info()->flags, 0, 0); - smp_mb(); if (!need_resched()) __sti_mwait(0, 0); else local_irq_enable(); } else local_irq_enable(); + __current_clr_polling(); } void select_idle_routine(const struct cpuinfo_x86 *c)