| Message ID | 1390339396-3479-69-git-send-email-paul.gortmaker@windriver.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 22 January 2014 02:53, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > None of these files are actually using any __init type directives > and hence don't need to include <linux/init.h>. Most are just a > left over from __devinit and __cpuinit removal, or simply due to > code getting copied from one driver to the next. > > Cc: Kevin Hilman <khilman@deeprootsystems.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/cpufreq/omap-cpufreq.c | 1 - > drivers/cpufreq/powernow-k8.c | 1 - > drivers/cpufreq/s3c2412-cpufreq.c | 1 - > drivers/cpufreq/s3c2440-cpufreq.c | 1 - > drivers/cpufreq/spear-cpufreq.c | 1 - > drivers/cpufreq/speedstep-lib.c | 1 - > 6 files changed, 6 deletions(-) We have discussed this in past where I pointed out this file is required by stuff like module_init, what happened to that query ? -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/21/14, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 22 January 2014 02:53, Paul Gortmaker <paul.gortmaker@windriver.com> > wrote: >> None of these files are actually using any __init type directives >> and hence don't need to include <linux/init.h>. Most are just a >> left over from __devinit and __cpuinit removal, or simply due to >> code getting copied from one driver to the next. >> >> Cc: Kevin Hilman <khilman@deeprootsystems.com> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: cpufreq@vger.kernel.org >> Cc: linux-pm@vger.kernel.org >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> --- >> drivers/cpufreq/omap-cpufreq.c | 1 - >> drivers/cpufreq/powernow-k8.c | 1 - >> drivers/cpufreq/s3c2412-cpufreq.c | 1 - >> drivers/cpufreq/s3c2440-cpufreq.c | 1 - >> drivers/cpufreq/spear-cpufreq.c | 1 - >> drivers/cpufreq/speedstep-lib.c | 1 - >> 6 files changed, 6 deletions(-) > > We have discussed this in past where I pointed out this file is required > by stuff like module_init, what happened to that query ? Patch 31/73 relocates module_init and similar macros to module.h so that is no longer an implicit dependency. https://lkml.org/lkml/2014/1/21/488 Thanks, Paul -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-arch" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index 590f5b6..6febc15 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -18,7 +18,6 @@ #include <linux/sched.h> #include <linux/cpufreq.h> #include <linux/delay.h> -#include <linux/init.h> #include <linux/err.h> #include <linux/clk.h> #include <linux/io.h> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index e10b646..386c4ad 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -30,7 +30,6 @@ #include <linux/kernel.h> #include <linux/smp.h> #include <linux/module.h> -#include <linux/init.h> #include <linux/cpufreq.h> #include <linux/slab.h> #include <linux/string.h> diff --git a/drivers/cpufreq/s3c2412-cpufreq.c b/drivers/cpufreq/s3c2412-cpufreq.c index 4645b48..8f42bac 100644 --- a/drivers/cpufreq/s3c2412-cpufreq.c +++ b/drivers/cpufreq/s3c2412-cpufreq.c @@ -10,7 +10,6 @@ * published by the Free Software Foundation. */ -#include <linux/init.h> #include <linux/module.h> #include <linux/interrupt.h> #include <linux/ioport.h> diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c index f84ed10..1aade6d 100644 --- a/drivers/cpufreq/s3c2440-cpufreq.c +++ b/drivers/cpufreq/s3c2440-cpufreq.c @@ -11,7 +11,6 @@ * published by the Free Software Foundation. */ -#include <linux/init.h> #include <linux/module.h> #include <linux/interrupt.h> #include <linux/ioport.h> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c index 5c86e3f..f481597 100644 --- a/drivers/cpufreq/spear-cpufreq.c +++ b/drivers/cpufreq/spear-cpufreq.c @@ -16,7 +16,6 @@ #include <linux/clk.h> #include <linux/cpufreq.h> #include <linux/err.h> -#include <linux/init.h> #include <linux/module.h> #include <linux/of_device.h> #include <linux/slab.h> diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c index 7047821..1ef6fb6 100644 --- a/drivers/cpufreq/speedstep-lib.c +++ b/drivers/cpufreq/speedstep-lib.c @@ -11,7 +11,6 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/init.h> #include <linux/cpufreq.h> #include <asm/msr.h>
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Cc: Kevin Hilman <khilman@deeprootsystems.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: cpufreq@vger.kernel.org Cc: linux-pm@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/cpufreq/omap-cpufreq.c | 1 - drivers/cpufreq/powernow-k8.c | 1 - drivers/cpufreq/s3c2412-cpufreq.c | 1 - drivers/cpufreq/s3c2440-cpufreq.c | 1 - drivers/cpufreq/spear-cpufreq.c | 1 - drivers/cpufreq/speedstep-lib.c | 1 - 6 files changed, 6 deletions(-)