| Message ID | 1394016605-24120-2-git-send-email-sebastian.capella@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Quoting Sebastian Capella (2014-03-05 02:50:04) > Use of tracers in local_irq_disable is causes recursive aborts when > called with irqs disabled and using a temporary stack (hibernation). > Replace local_irq_disable with raw_local_irq_disable instead to > avoid tracers. > > Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Robin Holt <robin.m.holt@gmail.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Konstantin Khlebnikov <k.khlebnikov@samsung.com> > Cc: Steven Capper <steve.capper@linaro.org> > Cc: Stephen Warren <swarren@nvidia.com> > Cc: Tejun Heo <tj@kernel.org> > --- > arch/arm/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > index 92f7b15..f58b723 100644 > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -100,7 +100,7 @@ void soft_restart(unsigned long addr) > u64 *stack = soft_restart_stack + ARRAY_SIZE(soft_restart_stack); > > /* Disable interrupts first */ > - local_irq_disable(); > + raw_local_irq_disable(); > local_fiq_disable(); > > /* Disable the L2 if we're the last man standing. */ > -- > 1.7.9.5 Hi, I have not heard any feedback on this change, since V3 of the patchset. Is everyone ok with this as it is? Thomas, thanks for proposing this, is this looking ok to you? Thanks! Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6 March 2014 15:45, Sebastian Capella <sebastian.capella@linaro.org> wrote: > Quoting Sebastian Capella (2014-03-05 02:50:04) >> Use of tracers in local_irq_disable is causes recursive aborts when >> called with irqs disabled and using a temporary stack (hibernation). >> Replace local_irq_disable with raw_local_irq_disable instead to >> avoid tracers. > I have not heard any feedback on this change, since V3 of the > patchset. > Is everyone ok with this as it is? > Thomas, thanks for proposing this, is this looking ok to you? ping I haven't received any further communication / acks on this particular patch, since Russell's ~approval below: On 26 February 2014 15:37, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > Great, I'm happy with this now. I assume that the plan is to submit this > to my patch system when everyone's given their fill of acks? Is this ok as it is? Thanks, Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 92f7b15..f58b723 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -100,7 +100,7 @@ void soft_restart(unsigned long addr) u64 *stack = soft_restart_stack + ARRAY_SIZE(soft_restart_stack); /* Disable interrupts first */ - local_irq_disable(); + raw_local_irq_disable(); local_fiq_disable(); /* Disable the L2 if we're the last man standing. */
Use of tracers in local_irq_disable is causes recursive aborts when called with irqs disabled and using a temporary stack (hibernation). Replace local_irq_disable with raw_local_irq_disable instead to avoid tracers. Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org> Cc: Russell King <linux@arm.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Deacon <will.deacon@arm.com> Cc: Robin Holt <robin.m.holt@gmail.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Konstantin Khlebnikov <k.khlebnikov@samsung.com> Cc: Steven Capper <steve.capper@linaro.org> Cc: Stephen Warren <swarren@nvidia.com> Cc: Tejun Heo <tj@kernel.org> --- arch/arm/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)