diff mbox

[1/3] arm64: Enable OPP

Message ID 1399653631-4938-1-git-send-email-broonie@kernel.org (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Mark Brown May 9, 2014, 4:40 p.m. UTC
From: Mark Brown <broonie@linaro.org>

Some of the generic drivers used on ARM class systems use OPP so allow it
to be selected in Kconfig. No code is required for this, it is not clear
to me why there is config for this option.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Nishanth Menon May 9, 2014, 5:02 p.m. UTC | #1
On Fri, May 9, 2014 at 11:40 AM, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Some of the generic drivers used on ARM class systems use OPP so allow it
> to be selected in Kconfig. No code is required for this, it is not clear
> to me why there is config for this option.
If you mean why we have ARCH_HAS_OPP,
http://lists-archives.com/linux-kernel/27401148-pm-hide-opp-configuration-when-socs-do-not-provide-an-implementation.html

>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  arch/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 8ccdd2646ae3..8256d6d09d33 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -2,6 +2,7 @@ config ARM64
>         def_bool y
>         select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
>         select ARCH_USE_CMPXCHG_LOCKREF
> +       select ARCH_HAS_OPP
>         select ARCH_HAS_SG_CHAIN
>         select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>         select ARCH_WANT_OPTIONAL_GPIOLIB
> --
> 2.0.0.rc2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown May 9, 2014, 5:11 p.m. UTC | #2
On Fri, May 09, 2014 at 12:02:12PM -0500, menon.nishanth@gmail.com wrote:
> On Fri, May 9, 2014 at 11:40 AM, Mark Brown <broonie@kernel.org> wrote:

> > Some of the generic drivers used on ARM class systems use OPP so allow it
> > to be selected in Kconfig. No code is required for this, it is not clear
> > to me why there is config for this option.

> If you mean why we have ARCH_HAS_OPP,
> http://lists-archives.com/linux-kernel/27401148-pm-hide-opp-configuration-when-socs-do-not-provide-an-implementation.html

That's for the user visible symbol but OPP is also enableable via select
- the fix here may be to remove both the visibility check and the
dependency.
Nishanth Menon May 9, 2014, 5:17 p.m. UTC | #3
On Fri, May 9, 2014 at 12:11 PM, Mark Brown <broonie@kernel.org> wrote:
> On Fri, May 09, 2014 at 12:02:12PM -0500, menon.nishanth@gmail.com wrote:
>> On Fri, May 9, 2014 at 11:40 AM, Mark Brown <broonie@kernel.org> wrote:
>
>> > Some of the generic drivers used on ARM class systems use OPP so allow it
>> > to be selected in Kconfig. No code is required for this, it is not clear
>> > to me why there is config for this option.
>
>> If you mean why we have ARCH_HAS_OPP,
>> http://lists-archives.com/linux-kernel/27401148-pm-hide-opp-configuration-when-socs-do-not-provide-an-implementation.html
>
> That's for the user visible symbol but OPP is also enableable via select
> - the fix here may be to remove both the visibility check and the
> dependency.
That is reasonable.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown May 9, 2014, 6:18 p.m. UTC | #4
On Fri, May 09, 2014 at 12:17:23PM -0500, menon.nishanth@gmail.com wrote:
> On Fri, May 9, 2014 at 12:11 PM, Mark Brown <broonie@kernel.org> wrote:

> > That's for the user visible symbol but OPP is also enableable via select
> > - the fix here may be to remove both the visibility check and the
> > dependency.

> That is reasonable.

OK, I've sent a patch - now I look at what the OPP stuff is doing that
definitely seems like a better approach.
diff mbox

Patch

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 8ccdd2646ae3..8256d6d09d33 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -2,6 +2,7 @@  config ARM64
 	def_bool y
 	select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
 	select ARCH_USE_CMPXCHG_LOCKREF
+	select ARCH_HAS_OPP
 	select ARCH_HAS_SG_CHAIN
 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
 	select ARCH_WANT_OPTIONAL_GPIOLIB