| Message ID | 1406792216-827-1-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 31 July 2014 13:06, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Having no license specification in a module taints the kernel during load > with: > > arm_big_little: module license 'unspecified' taints kernel. > > and also the linker doesn't allow it to make use of GPL-exported symbols > which in this case also results in errors like: > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > . The header of the driver specifies a GPL v2 license, so note that > accordingly. While at it also add a description and an author and fix > the license in a companion file to explicit v2. > > Reported-by: Andreas Schwab <schwab@suse.de> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/cpufreq/arm_big_little.c | 4 ++++ > drivers/cpufreq/arm_big_little_dt.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 1f4d4e315057..b600f3107bef 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > arm_bL_ops = NULL; > } > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > + > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c > index 8d9d59108906..4550f6976768 100644 > --- a/drivers/cpufreq/arm_big_little_dt.c > +++ b/drivers/cpufreq/arm_big_little_dt.c > @@ -114,4 +114,4 @@ module_platform_driver(generic_bL_platdrv); > > MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver via DT"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); Thanks.. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > Having no license specification in a module taints the kernel during load > with: > > arm_big_little: module license 'unspecified' taints kernel. > > and also the linker doesn't allow it to make use of GPL-exported symbols > which in this case also results in errors like: > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > . The header of the driver specifies a GPL v2 license, so note that > accordingly. While at it also add a description and an author and fix > the license in a companion file to explicit v2. > > Reported-by: Andreas Schwab <schwab@suse.de> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/cpufreq/arm_big_little.c | 4 ++++ > drivers/cpufreq/arm_big_little_dt.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 1f4d4e315057..b600f3107bef 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > arm_bL_ops = NULL; > } > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > + > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > +MODULE_LICENSE("GPL v2"); drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration specifiers or ‘...’ before string constant MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); ^ drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration specifiers or ‘...’ before string constant MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); ^ drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration specifiers or ‘...’ before string constant MODULE_LICENSE("GPL v2"); ^ Andreas.
On Thu, Aug 07, 2014 at 04:00:20PM +0200, Andreas Schwab wrote: > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > > Having no license specification in a module taints the kernel during load > > with: > > > > arm_big_little: module license 'unspecified' taints kernel. > > > > and also the linker doesn't allow it to make use of GPL-exported symbols > > which in this case also results in errors like: > > > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > > > . The header of the driver specifies a GPL v2 license, so note that > > accordingly. While at it also add a description and an author and fix > > the license in a companion file to explicit v2. > > > > Reported-by: Andreas Schwab <schwab@suse.de> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > drivers/cpufreq/arm_big_little.c | 4 ++++ > > drivers/cpufreq/arm_big_little_dt.c | 2 +- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > > index 1f4d4e315057..b600f3107bef 100644 > > --- a/drivers/cpufreq/arm_big_little.c > > +++ b/drivers/cpufreq/arm_big_little.c > > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > > arm_bL_ops = NULL; > > } > > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > > + > > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > > +MODULE_LICENSE("GPL v2"); > > drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration specifiers or ‘...’ before string constant > MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > ^ > drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration specifiers or ‘...’ before string constant > MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > ^ > drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration specifiers or ‘...’ before string constant > MODULE_LICENSE("GPL v2"); > ^ > Does adding #include <linux/module.h> in that file fix the problem? Uwe
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > Does adding > > #include <linux/module.h> > > in that file fix the problem? Yes, it does. Andreas.
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 1f4d4e315057..b600f3107bef 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) arm_bL_ops = NULL; } EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); + +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c index 8d9d59108906..4550f6976768 100644 --- a/drivers/cpufreq/arm_big_little_dt.c +++ b/drivers/cpufreq/arm_big_little_dt.c @@ -114,4 +114,4 @@ module_platform_driver(generic_bL_platdrv); MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver via DT"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2");
Having no license specification in a module taints the kernel during load with: arm_big_little: module license 'unspecified' taints kernel. and also the linker doesn't allow it to make use of GPL-exported symbols which in this case also results in errors like: arm_big_little: Unknown symbol cpufreq_register_driver (err 0) . The header of the driver specifies a GPL v2 license, so note that accordingly. While at it also add a description and an author and fix the license in a companion file to explicit v2. Reported-by: Andreas Schwab <schwab@suse.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/cpufreq/arm_big_little.c | 4 ++++ drivers/cpufreq/arm_big_little_dt.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)