From patchwork Tue Aug 26 01:31:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 4777441 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3F6AFC033A for ; Tue, 26 Aug 2014 01:32:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74C5E20145 for ; Tue, 26 Aug 2014 01:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45193201C0 for ; Tue, 26 Aug 2014 01:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbaHZBcY (ORCPT ); Mon, 25 Aug 2014 21:32:24 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:44204 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755362AbaHZBbS (ORCPT ); Mon, 25 Aug 2014 21:31:18 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NAW00HGB482LV50@mailout3.samsung.com>; Tue, 26 Aug 2014 10:31:15 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.113]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id E5.C2.04049.263EBF35; Tue, 26 Aug 2014 10:31:14 +0900 (KST) X-AuditID: cbfee68e-f79536d000000fd1-97-53fbe362f29b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 41.13.05196.263EBF35; Tue, 26 Aug 2014 10:31:14 +0900 (KST) Received: from chan.10.32.193.11 ([10.252.81.195]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NAW00BYG481L5A0@mmp2.samsung.com>; Tue, 26 Aug 2014 10:31:14 +0900 (KST) From: Chanwoo Choi To: eduardo.valentin@ti.com, amit.daniel@samsung.com, rui.zhang@intel.com Cc: kgene.kim@samsung.com, ch.naveen@samsung.com, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Valentin , Chanwoo Choi Subject: [PATCHv5 1/4] thermal: samsung: Exynos5260 and Exynos5420 should not use TRIM_RELOAD flag Date: Tue, 26 Aug 2014 10:31:02 +0900 Message-id: <1409016665-3824-2-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1409016665-3824-1-git-send-email-cw00.choi@samsung.com> References: <1409016665-3824-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsWyRsSkUDfp8e9ggzlnTS0aroZYbJyxntXi 7vPDjBbXvzxntViz/yeTxfwr11gtehdcZbM42/SG3WLTYyD38q45bBafe48wWsw4v4/J4snD PjYHXo+ds+6yeyze85LJY/OSeo++LasYPY7f2M7k8XmTXABbFJdNSmpOZllqkb5dAlfGlCWZ BVvFKi7PO83ewLhYuIuRg0NCwETiyr2ULkZOIFNM4sK99WxdjFwcQgJLGSW2nz/GBJEwkVi4 dTILiC0kMJ1R4up9ZoiiJiaJltlHwYrYBLQk9r+4wQZiiwh4Ssxd2MIEUsQssIdJoq/tOVi3 sECKxNvfq8AaWARUJWavWADWwCvgIjFx7zJmiG1yEh/2PGIHsTkFXCX+TznDDLHZRaJr3i9G kKESAsfYJSbdX8oKMUhA4tvkQywQ78hKbDoANUdS4uCKGywTGIUXMDKsYhRNLUguKE5KLzLS K07MLS7NS9dLzs/dxAiMk9P/nvXtYLx5wPoQowAHoxIP743438FCrIllxZW5hxhNgTZMZJYS Tc4HRmNeSbyhsZmRhamJqbGRuaWZkjhvgtTPYCGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2M HEu9j2xLUlReEVTCmC1a/OrsX7/Gx5LWLpck5p+3C2G+dun51j+sk99cnc4+edObFu1Tjsa2 h3q6ut5O3zxnn/jTy6Yree43HNG/LKJwd96xJ6Wrnz0Osy5ZW6JQwfZpcuPXl8/PCha7GVaZ Pa5581m5+GbAuYN3TuwUiw05wPJPcI/TqRRjIyWW4oxEQy3mouJEAIj6aYaOAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jQd2kx7+DDX4t0bFouBpisXHGelaL u88PM1pc//Kc1WLN/p9MFvOvXGO16F1wlc3ibNMbdotNj4Hcy7vmsFl87j3CaDHj/D4miycP +9gceD12zrrL7rF4z0smj81L6j36tqxi9Dh+YzuTx+dNcgFsUQ2MNhmpiSmpRQqpecn5KZl5 6bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAhyoplCXmlAKFAhKLi5X07TBNCA1x 07WAaYzQ9Q0JgusxMkADCWsYM6YsySzYKlZxed5p9gbGxcJdjJwcEgImEgu3TmaBsMUkLtxb zwZiCwlMZ5S4ep+5i5ELyG5ikmiZfZQJJMEmoCWx/8UNsCIRAU+JuQtbmECKmAX2MEn0tT0H myQskCLx9vcqsAYWAVWJ2SsWgDXwCrhITNy7jBlim5zEhz2P2EFsTgFXif9TzjBDbHaR6Jr3 i3ECI+8CRoZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGMFx+Ex6B+OqBotDjAIcjEo8vDfi fwcLsSaWFVfmHmKU4GBWEuFleAgU4k1JrKxKLcqPLyrNSS0+xGgKdNVEZinR5HxgisgriTc0 NjEzsjQyN7QwMjZXEuc92GodKCSQnliSmp2aWpBaBNPHxMEp1cDY5hRTtrU69fSXxqdr/u32 /N34f6uIQfjlFcrsZQvmHKzJehq30Wnn0///Xr2JdTh6bZphcclKdSG/g9u/vp2eqf5x7/uC ea+6Z98N3xcmdnhnJrPdwXiXm/WJVT8ytfUEZv1hPDw3xGCD9nLnibIiWeGaVRKxyxNkZ18v Uvh+R3jqU83WVJWZSizFGYmGWsxFxYkAuUvLpNkCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartlomiej Zolnierkiewicz Currently these SoCs claim TRIM_RELOAD support but don't have triminfo_ctrl register address defined in their struct exynos_tmu_registers entries. This causes incorrect write of value "1" to data->base + 0x00 address (which happens to be TRIMINFO register). Additionally according to the documentation that I have neither Exynos5260 nor Exynos5420 support/require TRIM_RELOAD feature. Thus fix the aforementioned issue by removing TMU_SUPPORT_TRIM_RELOAD flag for both Exynos5260 and Exynos5420. Cc: Naveen Krishna Chatradhi Cc: Amit Daniel Kachhap Cc: Eduardo Valentin Cc: Zhang Rui Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park --- drivers/thermal/samsung/exynos_tmu_data.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c index aa8e0de..8c0ada2 100644 --- a/drivers/thermal/samsung/exynos_tmu_data.c +++ b/drivers/thermal/samsung/exynos_tmu_data.c @@ -359,9 +359,8 @@ static const struct exynos_tmu_registers exynos5260_tmu_registers = { #define EXYNOS5260_TMU_DATA \ __EXYNOS5260_TMU_DATA \ .type = SOC_ARCH_EXYNOS5260, \ - .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \ - TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \ - TMU_SUPPORT_EMUL_TIME) + .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \ + TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME) struct exynos_tmu_init_data const exynos5260_default_tmu_data = { .tmu_data = { @@ -451,16 +450,15 @@ static const struct exynos_tmu_registers exynos5420_tmu_registers = { #define EXYNOS5420_TMU_DATA \ __EXYNOS5420_TMU_DATA \ .type = SOC_ARCH_EXYNOS5250, \ - .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \ - TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \ - TMU_SUPPORT_EMUL_TIME) + .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \ + TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME) #define EXYNOS5420_TMU_DATA_SHARED \ __EXYNOS5420_TMU_DATA \ .type = SOC_ARCH_EXYNOS5420_TRIMINFO, \ - .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \ - TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \ - TMU_SUPPORT_EMUL_TIME | TMU_SUPPORT_ADDRESS_MULTIPLE) + .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \ + TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME | \ + TMU_SUPPORT_ADDRESS_MULTIPLE) struct exynos_tmu_init_data const exynos5420_default_tmu_data = { .tmu_data = {