From patchwork Thu Aug 28 07:00:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pramod Gurav X-Patchwork-Id: 4790421 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DB1BEC0338 for ; Wed, 27 Aug 2014 18:36:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4FCD20158 for ; Wed, 27 Aug 2014 18:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06D14200FF for ; Wed, 27 Aug 2014 18:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935605AbaH0Sgl (ORCPT ); Wed, 27 Aug 2014 14:36:41 -0400 Received: from smtp117.ord1c.emailsrvr.com ([108.166.43.117]:48402 "EHLO smtp117.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932383AbaH0Sgk (ORCPT ); Wed, 27 Aug 2014 14:36:40 -0400 X-Greylist: delayed 499 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 Aug 2014 14:36:40 EDT Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp7.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 1455B3806AE; Wed, 27 Aug 2014 14:28:25 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp7.relay.ord1c.emailsrvr.com (Authenticated sender: pramod.gurav-AT-smartplayin.com) with ESMTPSA id 4039F380AB1; Wed, 27 Aug 2014 14:28:21 -0400 (EDT) X-Sender-Id: pramod.gurav@smartplayin.com Received: from localhost.localdomain ([UNAVAILABLE]. [27.7.163.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:465 (trex/5.2.10); Wed, 27 Aug 2014 18:28:25 GMT From: Pramod Gurav To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Cc: Pramod Gurav , Shawn Guo , "Rafael J. Wysocki" , Viresh Kumar Subject: [PATCH 2/3] cpufreq: cpu0: Removes unnecessary IS_ERR check on clk Date: Thu, 28 Aug 2014 00:00:11 -0700 Message-Id: <1409209212-18730-2-git-send-email-pramod.gurav@smartplayin.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1409209212-18730-1-git-send-email-pramod.gurav@smartplayin.com> References: <1409209212-18730-1-git-send-email-pramod.gurav@smartplayin.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_12_24, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This removes unnecessary IS_ERR check on clk when in failure path as execution wont reach till there with clk being a err. CC: Shawn Guo CC: "Rafael J. Wysocki" CC: Viresh Kumar Signed-off-by: Pramod Gurav Acked-by: Shawn Guo --- drivers/cpufreq/cpufreq-cpu0.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index e1574f8..0652cea 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -214,8 +214,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) out_free_table: dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table); out_put_clk: - if (!IS_ERR(cpu_clk)) - clk_put(cpu_clk); + clk_put(cpu_clk); out_put_reg: if (!IS_ERR(cpu_reg)) regulator_put(cpu_reg);