From patchwork Tue Sep 30 17:48:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 5005251 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CD7689F3EC for ; Tue, 30 Sep 2014 17:48:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F03A320200 for ; Tue, 30 Sep 2014 17:48:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF10120220 for ; Tue, 30 Sep 2014 17:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753201AbaI3Rss (ORCPT ); Tue, 30 Sep 2014 13:48:48 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:52380 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbaI3Rsr (ORCPT ); Tue, 30 Sep 2014 13:48:47 -0400 Received: by mail-pa0-f43.google.com with SMTP id hz1so7027799pad.30 for ; Tue, 30 Sep 2014 10:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=fZ8pzSiU0dPQXUMU6Zv/3yXIAcKUiiOHdfWtJ93v4+k=; b=qqK6xhfZ3P8yKpZaVcTSRQ21bBF3VWOiT/XhM0GZLB9uAqwy3K8LauV0jyDlBpHb7C hyKu8y8mzDc8VUdifjKm6ySIQxGuc6duftEmyLAwNUgnxla0Ll1BtCA3z1/DI9aPQKL0 oZnzWfrUUfVtpH+I3qKNRvMwAYAFYSUf2f/vaqvNd6CEJOcycMIyUMQS3QevjyBcpBdv whoNnUByALzmDykn2IsT+a9aQ1GwIsDxNzJ0EYcTWec0/syPXBTV7DVDwxjHBaE4CX8z emxatK26WV/0QaNpXCh+sS9PveJ+iRMployF/WTw34IM0VduPe5qnszzFsvhh1zefMbw er/A== X-Received: by 10.66.65.130 with SMTP id x2mr70787621pas.79.1412099327386; Tue, 30 Sep 2014 10:48:47 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id rj8sm15756957pdb.55.2014.09.30.10.48.46 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 30 Sep 2014 10:48:46 -0700 (PDT) From: Guenter Roeck To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, Dmitry Eremin-Solenikov , David Woodhouse , Santosh Shilimkar , linux-kernel@vger.kernel.org, Guenter Roeck , Loc Ho Subject: [PATCH v2 02/10] power/reset: xgene: Return -ENOMEM if out of memory Date: Tue, 30 Sep 2014 10:48:28 -0700 Message-Id: <1412099316-23167-3-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1412099316-23167-1-git-send-email-linux@roeck-us.net> References: <1412099316-23167-1-git-send-email-linux@roeck-us.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is customary to return an error code of -ENOMEM if the system is out of memory. Also, in that case, the infrastructure will report an error, so it is unnecessary to report it again. Cc: Loc Ho Signed-off-by: Guenter Roeck --- drivers/power/reset/xgene-reboot.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/power/reset/xgene-reboot.c b/drivers/power/reset/xgene-reboot.c index ecd55f8..20cf7c3 100644 --- a/drivers/power/reset/xgene-reboot.c +++ b/drivers/power/reset/xgene-reboot.c @@ -61,10 +61,8 @@ static int xgene_reboot_probe(struct platform_device *pdev) struct xgene_reboot_context *ctx; ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); - if (!ctx) { - dev_err(&pdev->dev, "out of memory for context\n"); - return -ENODEV; - } + if (!ctx) + return -ENOMEM; ctx->csr = of_iomap(pdev->dev.of_node, 0); if (!ctx->csr) {