From patchwork Sat Oct 4 23:31:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 5033221 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EEB95C11AB for ; Sat, 4 Oct 2014 23:31:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 265152016C for ; Sat, 4 Oct 2014 23:31:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43AB220122 for ; Sat, 4 Oct 2014 23:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbaJDXb3 (ORCPT ); Sat, 4 Oct 2014 19:31:29 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:39314 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbaJDXb2 (ORCPT ); Sat, 4 Oct 2014 19:31:28 -0400 Received: by mail-pd0-f180.google.com with SMTP id fp1so1369310pdb.25 for ; Sat, 04 Oct 2014 16:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=Rmzqd/6EXg9r4APoTH9QQPd3bhEEacJWeWU03PYOD6o=; b=ezWh+nMJ/mmZ9hj+t24RKU64pAMgeAlfA95s+wL93/NlYpVoZ5JKPf1RRSHOkWkfdr P8w2gyyWnl4HwdC5OY9rSMdlkQtKXaOzojMieq2Qftrr7PdugtCKitwP5kl2KrcUrtqH PMoL11cUJOJ7Dk/yjB4nk014eMukX+zHGcobY0WUWUz58W9qNb1R8hB7yiwYV6APcIeb PpZMw9j8VVjYeZK7NjdeTgP4TwA1NbFJQpxktRkimnUsh9tC1T14knbR/ap/qEtBqksm tlUoZL/8WcpDzGjex7mpC+T1wk2JkTFmw0yVg3pe2kCuH6I8u9FWFpkQuSEXS7zsU37C o5wA== X-Received: by 10.68.216.135 with SMTP id oq7mr15469839pbc.47.1412465488219; Sat, 04 Oct 2014 16:31:28 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id x13sm7464583pdk.22.2014.10.04.16.31.26 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 04 Oct 2014 16:31:27 -0700 (PDT) From: Guenter Roeck To: Sebastian Reichel Cc: Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH] power: ab8500_fg: Fix build warning Date: Sat, 4 Oct 2014 16:31:13 -0700 Message-Id: <1412465473-13495-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix drivers/power/ab8500_fg.c: In function 'ab8500_fg_probe': drivers/power/ab8500_fg.c:2989:27: warning: 'i' may be used uninitialized in this function drivers/power/ab8500_fg.c:2972:15: note: 'i' was declared here which actually points to a real bug. Signed-off-by: Guenter Roeck --- drivers/power/ab8500_fg.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c index 3cb4178..217da4b 100644 --- a/drivers/power/ab8500_fg.c +++ b/drivers/power/ab8500_fg.c @@ -2969,7 +2969,7 @@ static struct device_attribute ab8505_fg_sysfs_psy_attrs[] = { static int ab8500_fg_sysfs_psy_create_attrs(struct device *dev) { - unsigned int i, j; + unsigned int i; struct power_supply *psy = dev_get_drvdata(dev); struct ab8500_fg *di; @@ -2978,14 +2978,15 @@ static int ab8500_fg_sysfs_psy_create_attrs(struct device *dev) if (((is_ab8505(di->parent) || is_ab9540(di->parent)) && abx500_get_chip_id(dev->parent) >= AB8500_CUT2P0) || is_ab8540(di->parent)) { - for (j = 0; j < ARRAY_SIZE(ab8505_fg_sysfs_psy_attrs); j++) - if (device_create_file(dev, &ab8505_fg_sysfs_psy_attrs[j])) + for (i = 0; i < ARRAY_SIZE(ab8505_fg_sysfs_psy_attrs); i++) + if (device_create_file(dev, + &ab8505_fg_sysfs_psy_attrs[i])) goto sysfs_psy_create_attrs_failed_ab8505; } return 0; sysfs_psy_create_attrs_failed_ab8505: dev_err(dev, "Failed creating sysfs psy attrs for ab8505.\n"); - while (j--) + while (i--) device_remove_file(dev, &ab8505_fg_sysfs_psy_attrs[i]); return -EIO;