| Message ID | 1416514477-19190-4-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
Hi Stefan, On Thu, Nov 20, 2014 at 6:14 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote: > This patch enables the power subsystem for all i.MX28 boards. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/boot/dts/imx28.dtsi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 47f68ac..5c163a5 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -1022,8 +1022,12 @@ > }; > > power: power@80044000 { > + compatible = "fsl,imx28-power"; Should we have 'fsl,imx23-power' and 'fsl,imx28-power' as compatible strings? Or ''fsl,mxs-power' could be used for both? -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Fabio, > Fabio Estevam <festevam@gmail.com> hat am 20. November 2014 um 22:32 > geschrieben: > > > Hi Stefan, > > On Thu, Nov 20, 2014 at 6:14 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote: > > This patch enables the power subsystem for all i.MX28 boards. > > > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > > --- > > arch/arm/boot/dts/imx28.dtsi | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > > index 47f68ac..5c163a5 100644 > > --- a/arch/arm/boot/dts/imx28.dtsi > > +++ b/arch/arm/boot/dts/imx28.dtsi > > @@ -1022,8 +1022,12 @@ > > }; > > > > power: power@80044000 { > > + compatible = "fsl,imx28-power"; > > Should we have 'fsl,imx23-power' and 'fsl,imx28-power' as compatible strings? yes, of course. > > Or ''fsl,mxs-power' could be used for both? I think that would be a bad idea. I can't believe that all PMU register of i.MX23 and i.MX28 are identical. So in the future we will have to distinguish between them. It's better to do it now like most of the mxs driver does. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 20, 2014 at 8:57 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote: >> Or ''fsl,mxs-power' could be used for both? > > I think that would be a bad idea. I can't believe that all PMU register of > i.MX23 and i.MX28 are identical. So in the future we will have to distinguish > between them. It's better to do it now like most of the mxs driver does. Ok, sounds good then. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 47f68ac..5c163a5 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1022,8 +1022,12 @@ }; power: power@80044000 { + compatible = "fsl,imx28-power"; + #address-cells = <1>; + #size-cells = <1>; reg = <0x80044000 0x2000>; - status = "disabled"; + interrupts = <6>; + ranges; }; saif1: saif@80046000 {
This patch enables the power subsystem for all i.MX28 boards. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/imx28.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html