| Message ID | 1420538528-5236-3-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Tue, Jan 6, 2015 at 11:02 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Shimoda-san, On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > Since the ctemp is used for rcar_thermal_write() in > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > of "int". In your V2, can you please include in your description that you are also updating the helper variables 'old' and 'new'? The description does not mention it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/thermal/rcar_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index bbdf64e..6dcead1 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -63,7 +63,7 @@ struct rcar_thermal_priv { > struct mutex lock; > struct list_head list; > int id; > - int ctemp; > + u32 ctemp; > }; > > #define rcar_thermal_for_each_priv(pos, common) \ > @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) > { > struct device *dev = rcar_priv_to_dev(priv); > int i; > - int ctemp, old, new; > + u32 ctemp, old, new; But you also update them, as necessary. > int ret = -EINVAL; > > mutex_lock(&priv->lock); > -- > 1.7.9.5 > BR, Eduardo Valentin
Hi Eduardo-san, > Shimoda-san, > > On Tue, Jan 06, 2015 at 07:02:08PM +0900, Yoshihiro Shimoda wrote: > > Since the ctemp is used for rcar_thermal_write() in > > rcar_thermal_update_temp(), the type of ctemp should be "u32" instead > > of "int". > > In your V2, can you please include in your description that you are also > updating the helper variables 'old' and 'new'? > > The description does not mention it. Thank you for the point. I will fix this description in v2 patch set. Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index bbdf64e..6dcead1 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -63,7 +63,7 @@ struct rcar_thermal_priv { struct mutex lock; struct list_head list; int id; - int ctemp; + u32 ctemp; }; #define rcar_thermal_for_each_priv(pos, common) \ @@ -145,7 +145,7 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) { struct device *dev = rcar_priv_to_dev(priv); int i; - int ctemp, old, new; + u32 ctemp, old, new; int ret = -EINVAL; mutex_lock(&priv->lock);
Since the ctemp is used for rcar_thermal_write() in rcar_thermal_update_temp(), the type of ctemp should be "u32" instead of "int". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/thermal/rcar_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)