| Message ID | 1422553145-14798-1-git-send-email-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thu, Jan 29, 2015 at 6:39 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > The commit "PM: Make dev_pm_get_subsys_data() always return 0 on success" > changed the return value from dev_pm_get_subsys_data(). Let's update the > comment in the function header to reflect this change as well. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, January 29, 2015 06:39:04 PM Ulf Hansson wrote: > The commit "PM: Make dev_pm_get_subsys_data() always return 0 on success" > changed the return value from dev_pm_get_subsys_data(). Let's update the > comment in the function header to reflect this change as well. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> [1-2/2] queued up for 3.20, thanks! > --- > drivers/base/power/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c > index b0f1388..a1ee51d 100644 > --- a/drivers/base/power/common.c > +++ b/drivers/base/power/common.c > @@ -19,8 +19,8 @@ > * @dev: Device to handle. > * > * If power.subsys_data is NULL, point it to a new object, otherwise increment > - * its reference counter. Return 1 if a new object has been created, otherwise > - * return 0 or error code. > + * its reference counter. Return 0 if new object has been created or refcount > + * increased, otherwise negative error code. > */ > int dev_pm_get_subsys_data(struct device *dev) > { >
diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c index b0f1388..a1ee51d 100644 --- a/drivers/base/power/common.c +++ b/drivers/base/power/common.c @@ -19,8 +19,8 @@ * @dev: Device to handle. * * If power.subsys_data is NULL, point it to a new object, otherwise increment - * its reference counter. Return 1 if a new object has been created, otherwise - * return 0 or error code. + * its reference counter. Return 0 if new object has been created or refcount + * increased, otherwise negative error code. */ int dev_pm_get_subsys_data(struct device *dev) {
The commit "PM: Make dev_pm_get_subsys_data() always return 0 on success" changed the return value from dev_pm_get_subsys_data(). Let's update the comment in the function header to reflect this change as well. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/base/power/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)