| Message ID | 1423088075-10025-4-git-send-email-marek@goldelico.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Wed, Feb 04, 2015 at 11:14:32PM +0100, Marek Belisko wrote: > + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values > + for charging calibration (see example) > + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values > + for discharging calibration (see example) Please prefix these properties with "ti," -- Sebastian
On Wed 2015-02-04 23:14:32, Marek Belisko wrote: > Signed-off-by: Marek Belisko <marek@goldelico.com> > --- > .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt > > diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt > new file mode 100644 > index 0000000..bb3580c > --- /dev/null > +++ b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt > @@ -0,0 +1,43 @@ > +twl4030_madc_battery > + > +Required properties: > + - compatible : "ti,twl4030-madc-battery" > + - capacity-uah : battery capacity in uAh Could we make it capacity-uAh ? > + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values > + for charging calibration (see example) > + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values > + for discharging calibration (see example) Would "mV-to-capacity..." be more accurate? Also, would it make sense to introduce coefficients for temperature and discharge rate? Thanks, Pavel
On Mon, Mar 16, 2015 at 10:05 PM, Pavel Machek <pavel@ucw.cz> wrote: > On Wed 2015-02-04 23:14:32, Marek Belisko wrote: >> Signed-off-by: Marek Belisko <marek@goldelico.com> >> --- >> .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >> >> diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >> new file mode 100644 >> index 0000000..bb3580c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >> @@ -0,0 +1,43 @@ >> +twl4030_madc_battery >> + >> +Required properties: >> + - compatible : "ti,twl4030-madc-battery" >> + - capacity-uah : battery capacity in uAh > > Could we make it capacity-uAh ? This name was suggested by Mark Rutland [1] and naming convention should be all lowercase. There exists already bindings without uppercase (e.g. ti,bb-uamp) so I would keep it consistent. > >> + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values >> + for charging calibration (see example) >> + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values >> + for discharging calibration (see example) > > Would "mV-to-capacity..." be more accurate? Also, would it make sense Again maybe mv but it can be added also later. > to introduce coefficients for temperature and discharge rate? What do you mean? Nothing like that is used in current driver why do we need to add it? > > Thanks, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [1] - http://lists.openwall.net/linux-kernel/2014/10/09/104 BR, marek
Am 16.03.2015 um 22:20 schrieb Belisko Marek <marek.belisko@gmail.com>: > On Mon, Mar 16, 2015 at 10:05 PM, Pavel Machek <pavel@ucw.cz> wrote: >> On Wed 2015-02-04 23:14:32, Marek Belisko wrote: >>> Signed-off-by: Marek Belisko <marek@goldelico.com> >>> --- >>> .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >>> >>> diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >>> new file mode 100644 >>> index 0000000..bb3580c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt >>> @@ -0,0 +1,43 @@ >>> +twl4030_madc_battery >>> + >>> +Required properties: >>> + - compatible : "ti,twl4030-madc-battery" >>> + - capacity-uah : battery capacity in uAh >> >> Could we make it capacity-uAh ? > This name was suggested by Mark Rutland [1] and naming convention > should be all lowercase. There exists already bindings > without uppercase (e.g. ti,bb-uamp) so I would keep it consistent. >> >>> + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values >>> + for charging calibration (see example) >>> + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values >>> + for discharging calibration (see example) >> >> Would "mV-to-capacity..." be more accurate? Also, would it make sense > Again maybe mv but it can be added also later. >> to introduce coefficients for temperature and discharge rate? > What do you mean? Nothing like that is used in current driver why do > we need to add it? Temperature calibration should have already been done in the underlaying twl4030 iio driver. Discharge rate is the real current flow reported in uA. Also reported by iio. >> >> Thanks, >> Pavel >> -- >> (english) http://www.livejournal.com/~pavelmachek >> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > > [1] - http://lists.openwall.net/linux-kernel/2014/10/09/104 > > BR, > > marek > BR, Nikolaus -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Temperature calibration should have already been done in the underlaying twl4030 iio driver. > > Discharge rate is the real current flow reported in uA. Also > reported by iio. Ack, but there's rather severe temperature dependency of the lithium battery, which you should take into account if you want to compute "percentage charged". Pavel
Am 17.03.2015 um 09:48 schrieb Pavel Machek <pavel@ucw.cz>: >> >> Temperature calibration should have already been done in the underlaying twl4030 iio driver. >> >> Discharge rate is the real current flow reported in uA. Also >> reported by iio. > > Ack, but there's rather severe temperature dependency of the lithium > battery, which you should take into account if you want to compute > “percentage charged". We just want to estimate it as good as possible. 5-10% is sufficient and better than no value at all (which is what you get without this driver). And, we just convert the (existing) driver from non-DT to DT and to use iio, so we do not want to change the inner logic what it does and how it works. BR, Nikolaus -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt new file mode 100644 index 0000000..bb3580c --- /dev/null +++ b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt @@ -0,0 +1,43 @@ +twl4030_madc_battery + +Required properties: + - compatible : "ti,twl4030-madc-battery" + - capacity-uah : battery capacity in uAh + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values + for charging calibration (see example) + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values + for discharging calibration (see example) + - io-channels: Should contain IIO channel specifiers + for each element in io-channel-names. +- io-channel-names: Should contain the following values: + * "temp" - The ADC channel for temperature reading + * "ichg" - The ADC channel for battery charging status + * "vbat" - The ADC channel to measure the battery voltage + +Example: + madc-battery { + compatible = "ti,twl4030-madc-battery"; + capacity-uah = <1200000>; + volt-to-capacity-charging-map = <4200 100>, + <4100 75>, + <4000 55>, + <3900 25>, + <3800 5>, + <3700 2>, + <3600 1>, + <3300 0>; + + volt-to-capacity-discharging-map = <4200 100> + <4100 95>, + <4000 70>, + <3800 50>, + <3700 10>, + <3600 5>, + <3300 0>; + io-channels = <&twl_madc 1>, + <&twl_madc 10>, + <&twl_madc 12>; + io-channel-names = "temp", + "ichg", + "vbat"; + };
Signed-off-by: Marek Belisko <marek@goldelico.com> --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt