| Message ID | 1427718438-31098-2-git-send-email-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 30 March 2015 at 17:57, Sudeep Holla <sudeep.holla@arm.com> wrote: > The "cpu-cluster.<n>" used to get the cluster clock is not used by any > platform. Moreover __of_clk_get_by_name used in clk_get return error if > the "clock-names" in the DT doesn't match this string. When using DT, > it's not compulsory to specify the clock name unless there are multiple > clock input entries in the consumer. > > This patch removes the unused clock string from the driver. > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/cpufreq/arm_big_little.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 3fc676c63f91..813315cd0247 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -324,7 +324,6 @@ static void put_cluster_clk_and_freq_table(struct device *cpu_dev) > static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) > { > u32 cluster = raw_cpu_to_cluster(cpu_dev->id); > - char name[14] = "cpu-cluster."; > int ret; > > if (freq_table[cluster]) > @@ -344,8 +343,7 @@ static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) > goto free_opp_table; > } > > - name[12] = cluster + '0'; > - clk[cluster] = clk_get(cpu_dev, name); > + clk[cluster] = clk_get(cpu_dev, NULL); > if (!IS_ERR(clk[cluster])) { > dev_dbg(cpu_dev, "%s: clk: %p & freq table: %p, cluster: %d\n", > __func__, clk[cluster], freq_table[cluster], What about non-DT platforms? Yeah, even I am not sure if any such platform will be there on not, using this driver.. But otherwise, Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30/03/15 14:31, Viresh Kumar wrote: > On 30 March 2015 at 17:57, Sudeep Holla <sudeep.holla@arm.com> wrote: >> The "cpu-cluster.<n>" used to get the cluster clock is not used by any >> platform. Moreover __of_clk_get_by_name used in clk_get return error if >> the "clock-names" in the DT doesn't match this string. When using DT, >> it's not compulsory to specify the clock name unless there are multiple >> clock input entries in the consumer. >> >> This patch removes the unused clock string from the driver. >> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/cpufreq/arm_big_little.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c >> index 3fc676c63f91..813315cd0247 100644 [...] >> @@ -344,8 +343,7 @@ static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) >> goto free_opp_table; >> } >> >> - name[12] = cluster + '0'; >> - clk[cluster] = clk_get(cpu_dev, name); >> + clk[cluster] = clk_get(cpu_dev, NULL); >> if (!IS_ERR(clk[cluster])) { >> dev_dbg(cpu_dev, "%s: clk: %p & freq table: %p, cluster: %d\n", >> __func__, clk[cluster], freq_table[cluster], > > What about non-DT platforms? Yeah, even I am not sure if any such > platform will be there on not, using this driver.. > Hope we don't have any in future :) > But otherwise, > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 3fc676c63f91..813315cd0247 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -324,7 +324,6 @@ static void put_cluster_clk_and_freq_table(struct device *cpu_dev) static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) { u32 cluster = raw_cpu_to_cluster(cpu_dev->id); - char name[14] = "cpu-cluster."; int ret; if (freq_table[cluster]) @@ -344,8 +343,7 @@ static int _get_cluster_clk_and_freq_table(struct device *cpu_dev) goto free_opp_table; } - name[12] = cluster + '0'; - clk[cluster] = clk_get(cpu_dev, name); + clk[cluster] = clk_get(cpu_dev, NULL); if (!IS_ERR(clk[cluster])) { dev_dbg(cpu_dev, "%s: clk: %p & freq table: %p, cluster: %d\n", __func__, clk[cluster], freq_table[cluster],
The "cpu-cluster.<n>" used to get the cluster clock is not used by any platform. Moreover __of_clk_get_by_name used in clk_get return error if the "clock-names" in the DT doesn't match this string. When using DT, it's not compulsory to specify the clock name unless there are multiple clock input entries in the consumer. This patch removes the unused clock string from the driver. Cc: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/cpufreq/arm_big_little.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)