From patchwork Sun Apr 12 04:10:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Smythies X-Patchwork-Id: 6202581 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3F671BF4A6 for ; Sun, 12 Apr 2015 04:11:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0044F20265 for ; Sun, 12 Apr 2015 04:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 152A82024F for ; Sun, 12 Apr 2015 04:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbbDLELc (ORCPT ); Sun, 12 Apr 2015 00:11:32 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:33522 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbbDLELc (ORCPT ); Sun, 12 Apr 2015 00:11:32 -0400 Received: by pdbnk13 with SMTP id nk13so68262773pdb.0 for ; Sat, 11 Apr 2015 21:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QpVwkrrtFcnBd4x/vJ8/bhYMnUV/ofP6s0bgTLe5MtA=; b=S1Tqw6xedpkc15q9uqlRuwZN7uLEiUjdWaXx9LaIwIZZQC0CEZvxALRuAOMBTmgDxE HgH4DaLOAYC//D+JBEJqnzQXEdyrfwhhxS8AyC9Fix/WEvPalS7JQFTLmHvQkDvlqOYS 66m5PLoOpRV09CzwoS3HRu6wuTAa7zf34A2aUGVi6GNy+fi/iIUuRIKq5y9GPDc022kY t/caGk1Dt1hYibMd+VHmoEvK5GcawvNmTDpGyiP0KUogAeLDr712vswxmvN9PEEXGn3Z Y8S2mzgpiBg2ScvaIITpzcvafvP5kBAGlNuETNYTMCvwxRBFIOQrF8M8bkzy+RZCI4cq aLuQ== X-Received: by 10.70.131.132 with SMTP id om4mr15389532pdb.30.1428811891658; Sat, 11 Apr 2015 21:11:31 -0700 (PDT) Received: from s15.smythies.com (s173-180-45-4.bc.hsia.telus.net. [173.180.45.4]) by mx.google.com with ESMTPSA id zt9sm3356413pac.9.2015.04.11.21.11.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Apr 2015 21:11:31 -0700 (PDT) From: Doug Smythies X-Google-Original-From: Doug Smythies To: kristen@linux.intel.com, rjw@rjwysocki.net Cc: dsmythies@telus.net, linux-pm@vger.kernel.org Subject: [PATCH 5/5] intel_pstate: Adjust default IIR filter gain. Date: Sat, 11 Apr 2015 21:10:30 -0700 Message-Id: <1428811830-15006-6-git-send-email-dsmythies@telus.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1428811830-15006-1-git-send-email-dsmythies@telus.net> References: <1428811830-15006-1-git-send-email-dsmythies@telus.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A default IIR filter gain of 10 percent is recommended. It best matches a rising edge step function load increase response time to the previous version of this driver. Although not by a lot, it better damps lower frequency load / sleep rate response oscillations. Signed-off-by: Doug Smythies --- drivers/cpufreq/intel_pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 66e662d..a374309 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -626,7 +626,7 @@ static struct cpu_defaults core_params = { .sample_rate_ms = 10, .deadband = 0, .setpoint = 97, - .p_gain_pct = 20, + .p_gain_pct = 10, .d_gain_pct = 0, .i_gain_pct = 0, .c0_ceiling = 950, @@ -646,7 +646,7 @@ static struct cpu_defaults byt_params = { .sample_rate_ms = 10, .deadband = 0, .setpoint = 97, - .p_gain_pct = 20, + .p_gain_pct = 10, .d_gain_pct = 0, .i_gain_pct = 4, .c0_ceiling = 950,