| Message ID | 1432590731-9194-1-git-send-email-ashwin.chaugule@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, 2015-05-25 at 17:52 -0400, Ashwin Chaugule wrote: > CPPC is the first client to make use of the PCC Mailbox channel. So > enable it only when CPPC is also enabled. > > Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> > --- > drivers/mailbox/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index 84b0a2d..60c8da6 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -45,7 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE > > config PCC > bool "Platform Communication Channel Driver" > - depends on ACPI > + depends on ACPI && ACPI_CPPC If we add such dependency then we will end up in adding many .. Is there any specific reason, you want to to do this? Thanks, Srinivas > help > ACPI 5.0+ spec defines a generic mode of communication > between the OS and a platform such as the BMC. This medium
On Tuesday, May 26, 2015 09:37:45 PM Pandruvada, Srinivas wrote: > On Mon, 2015-05-25 at 17:52 -0400, Ashwin Chaugule wrote: > > CPPC is the first client to make use of the PCC Mailbox channel. So > > enable it only when CPPC is also enabled. > > > > Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> > > --- > > drivers/mailbox/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > > index 84b0a2d..60c8da6 100644 > > --- a/drivers/mailbox/Kconfig > > +++ b/drivers/mailbox/Kconfig > > @@ -45,7 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE > > > > config PCC > > bool "Platform Communication Channel Driver" > > - depends on ACPI > > + depends on ACPI && ACPI_CPPC > If we add such dependency then we will end up in adding many .. > Is there any specific reason, you want to to do this? The reason is that we want PCC to only be enabled if there's any user of it. However, it would be better to make (a) PCC default to unset and (b) ACPI_CPPC select PCC for this purpose.
On 26 May 2015 at 20:43, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, May 26, 2015 09:37:45 PM Pandruvada, Srinivas wrote: >> On Mon, 2015-05-25 at 17:52 -0400, Ashwin Chaugule wrote: >> > CPPC is the first client to make use of the PCC Mailbox channel. So >> > enable it only when CPPC is also enabled. >> > >> > Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> >> > --- >> > drivers/mailbox/Kconfig | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig >> > index 84b0a2d..60c8da6 100644 >> > --- a/drivers/mailbox/Kconfig >> > +++ b/drivers/mailbox/Kconfig >> > @@ -45,7 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE >> > >> > config PCC >> > bool "Platform Communication Channel Driver" >> > - depends on ACPI >> > + depends on ACPI && ACPI_CPPC >> If we add such dependency then we will end up in adding many .. >> Is there any specific reason, you want to to do this? > > The reason is that we want PCC to only be enabled if there's any user of it. > > However, it would be better to make (a) PCC default to unset and > (b) ACPI_CPPC select PCC for this purpose. I believe I have (b) already. Will make PCC default to unset. Thanks, Ashwin. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index 84b0a2d..60c8da6 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -45,7 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE config PCC bool "Platform Communication Channel Driver" - depends on ACPI + depends on ACPI && ACPI_CPPC help ACPI 5.0+ spec defines a generic mode of communication between the OS and a platform such as the BMC. This medium
CPPC is the first client to make use of the PCC Mailbox channel. So enable it only when CPPC is also enabled. Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> --- drivers/mailbox/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)