From patchwork Sun May 31 14:46:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Smythies X-Patchwork-Id: 6516081 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 28787C0020 for ; Sun, 31 May 2015 14:47:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E35472061C for ; Sun, 31 May 2015 14:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA90D20619 for ; Sun, 31 May 2015 14:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758294AbbEaOq7 (ORCPT ); Sun, 31 May 2015 10:46:59 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33372 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756380AbbEaOq6 (ORCPT ); Sun, 31 May 2015 10:46:58 -0400 Received: by padj3 with SMTP id j3so25804042pad.0 for ; Sun, 31 May 2015 07:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=DGSXaApeKWEFIfk0yLvTxOaKieetDG0moIRo5NeW++k=; b=RbaKpgqYzpC0xTEGAYecLVR+UIXUjsO8HKJjVwlrzlBw7tPjoZtgmgihk+pWz75ZX1 oKOSkzAHyn/LINX2Uh2ntuLgEux8inePe/scVD2/RoPwhh3++WL0GH6ZZhLasuLD/RK5 ycVrkOMXksUg8FQyvSpcKz4H6s8qpfIGXG2c9Ffo2Cc0doPUEBzk/vvXJG/pt+Z+DACC ndawDdi1jh7Y0xGlOgsszivcyh97Nk2FVfzhlUvSZ9WN0vAb9e7rkdJObj2XycRLJt1z l6lVSSu7ROihN9Yvc6cbFaUU//KPRAGLRipQ1dEdefHgcgnvcmQPvzSlJMt/dtVV3TMH g06Q== X-Received: by 10.66.179.81 with SMTP id de17mr32312753pac.59.1433083618354; Sun, 31 May 2015 07:46:58 -0700 (PDT) Received: from s15.smythies.com (s173-180-45-4.bc.hsia.telus.net. [173.180.45.4]) by mx.google.com with ESMTPSA id q5sm11484769pde.56.2015.05.31.07.46.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 31 May 2015 07:46:57 -0700 (PDT) From: Doug Smythies X-Google-Original-From: Doug Smythies To: kristen@linux.intel.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org Cc: dsmythies@telus.net Subject: [PATCH] intel_pstate: change some inconsistent debug information. Date: Sun, 31 May 2015 07:46:47 -0700 Message-Id: <1433083607-4150-1-git-send-email-dsmythies@telus.net> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In a previous revision, commit ce717613f3fb531dea3e11c8c24d80585331f137 turned per cpu printk into pr_debug. However, only half of the change was done, introducing an inconsistency between entry and exit from driver pstate control. This patch changes the exit message to pr_debug also. The various messages are inconsistent with respect to any identifier text that can be used to help isolate the desired information from a huge log. This patch makes a consistent identifier portion of the string. Signed-off-by: Doug Smythies --- drivers/cpufreq/intel_pstate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 77b6edf..cbf1890 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -399,7 +399,7 @@ static ssize_t store_no_turbo(struct kobject *a, struct attribute *b, update_turbo_state(); if (limits.turbo_disabled) { - pr_warn("Turbo disabled by BIOS or unavailable on processor\n"); + pr_warn("intel_pstate: Turbo disabled by BIOS or unavailable on processor\n"); return -EPERM; } @@ -487,7 +487,7 @@ static void __init intel_pstate_sysfs_expose_params(void) static void intel_pstate_hwp_enable(void) { hwp_active++; - pr_info("intel_pstate HWP enabled\n"); + pr_info("intel_pstate: HWP enabled\n"); wrmsrl( MSR_PM_ENABLE, 0x1); } @@ -940,7 +940,7 @@ static int intel_pstate_init_cpu(unsigned int cpunum) add_timer_on(&cpu->timer, cpunum); - pr_debug("Intel pstate controlling: cpu %d\n", cpunum); + pr_debug("intel_pstate: controlling: cpu %d\n", cpunum); return 0; } @@ -1006,7 +1006,7 @@ static void intel_pstate_stop_cpu(struct cpufreq_policy *policy) int cpu_num = policy->cpu; struct cpudata *cpu = all_cpu_data[cpu_num]; - pr_info("intel_pstate CPU %d exiting\n", cpu_num); + pr_debug("intel_pstate: CPU %d exiting\n", cpu_num); del_timer_sync(&all_cpu_data[cpu_num]->timer); if (hwp_active)