diff mbox

PM / Domains: Make pm_genpd_init() available to modules

Message ID 1439446917-32304-1-git-send-email-rnayak@codeaurora.org (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Rajendra Nayak Aug. 13, 2015, 6:21 a.m. UTC
Export symbol pm_genpd_init so it can be used in loadable
kernel modules

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/base/power/domain.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd Aug. 13, 2015, 6:11 p.m. UTC | #1
On 08/13, Rajendra Nayak wrote:
> Export symbol pm_genpd_init so it can be used in loadable
> kernel modules
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---

I'd like to take this through the clk tree somehow so that we can
merge the rest of the GDSC series this coming cycle.
Geert Uytterhoeven Aug. 14, 2015, 7:56 a.m. UTC | #2
On Thu, Aug 13, 2015 at 8:21 AM, Rajendra Nayak <rnayak@codeaurora.org> wrote:
> Export symbol pm_genpd_init so it can be used in loadable
> kernel modules
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

Assuming you're aware of the consequences:
  - Modular PM Domain drivers don't work for "critical" devices where the
    driver is started from *OF_DECLARE(),
  - This may depend on "PM / Domains: Return -EPROBE_DEFER if we fail to
    init or turn-on domain" in pm/linux-next
    https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=311fa6adf92c5110057daa439fdaff012864aa2b

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rajendra Nayak Aug. 17, 2015, 4:17 a.m. UTC | #3
On 08/13/2015 11:41 PM, Stephen Boyd wrote:
> On 08/13, Rajendra Nayak wrote:
>> Export symbol pm_genpd_init so it can be used in loadable
>> kernel modules
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>
> I'd like to take this through the clk tree somehow so that we can
> merge the rest of the GDSC series this coming cycle.

Ulf/Rafael, if you don't have any issues with the patch, and are fine
with Stephen taking this through the clk tree, would you be able to ack
this please? thanks.

regards,
Rajendra
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kevin Hilman Aug. 25, 2015, 6:08 p.m. UTC | #4
Geert Uytterhoeven <geert@linux-m68k.org> writes:

> On Thu, Aug 13, 2015 at 8:21 AM, Rajendra Nayak <rnayak@codeaurora.org> wrote:
>> Export symbol pm_genpd_init so it can be used in loadable
>> kernel modules
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Assuming you're aware of the consequences:
>   - Modular PM Domain drivers don't work for "critical" devices where the
>     driver is started from *OF_DECLARE(),
>   - This may depend on "PM / Domains: Return -EPROBE_DEFER if we fail to
>     init or turn-on domain" in pm/linux-next
>     https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=311fa6adf92c5110057daa439fdaff012864aa2b
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Right, things can get "interesting" and there are known limitations, but
we shouldn't prevent it, and also it might help us fix the above
limitations.

Acked-by: Kevin Hilman <khilman@linaro.org>

Rafael, can you pick this one up?  I think it's better to go through the
PM tree.  v4.2 would be ideal, but I realize it's probably a bit late
for that.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 0ee43c1..578d121 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1952,6 +1952,7 @@  void pm_genpd_init(struct generic_pm_domain *genpd,
 	list_add(&genpd->gpd_list_node, &gpd_list);
 	mutex_unlock(&gpd_list_lock);
 }
+EXPORT_SYMBOL_GPL(pm_genpd_init);
 
 #ifdef CONFIG_PM_GENERIC_DOMAINS_OF
 /*