| Message ID | 1441732403-7248-1-git-send-email-b.zolnierkie@samsung.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote: > CONFIG_PM ifdefs are superfluous and can be removed. > > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Alexandre Courbot <gnurou@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> What tree does this apply to? > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c > index 8084c7f..2bd6284 100644 > --- a/drivers/cpufreq/tegra20-cpufreq.c > +++ b/drivers/cpufreq/tegra20-cpufreq.c > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = { > .exit = tegra_cpu_exit, > .name = "tegra", > .attr = cpufreq_generic_attr, > -#ifdef CONFIG_PM > .suspend = cpufreq_generic_suspend, > -#endif > }; > > static int __init tegra_cpufreq_init(void) >
On 08-09-15, 19:13, Bartlomiej Zolnierkiewicz wrote: > CONFIG_PM ifdefs are superfluous and can be removed. > > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Alexandre Courbot <gnurou@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c > index 8084c7f..2bd6284 100644 > --- a/drivers/cpufreq/tegra20-cpufreq.c > +++ b/drivers/cpufreq/tegra20-cpufreq.c > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = { > .exit = tegra_cpu_exit, > .name = "tegra", > .attr = cpufreq_generic_attr, > -#ifdef CONFIG_PM > .suspend = cpufreq_generic_suspend, > -#endif > }; > > static int __init tegra_cpufreq_init(void) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi, On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote: > On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote: > > CONFIG_PM ifdefs are superfluous and can be removed. > > > > Cc: Stephen Warren <swarren@wwwdotorg.org> > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: Alexandre Courbot <gnurou@gmail.com> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > What tree does this apply to? It applies fine to both next (next-20150909 branch) and current Linus' tree (top commit is a794b4f). > > --- > > drivers/cpufreq/tegra20-cpufreq.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c > > index 8084c7f..2bd6284 100644 > > --- a/drivers/cpufreq/tegra20-cpufreq.c > > +++ b/drivers/cpufreq/tegra20-cpufreq.c > > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = { > > .exit = tegra_cpu_exit, > > .name = "tegra", > > .attr = cpufreq_generic_attr, > > -#ifdef CONFIG_PM > > .suspend = cpufreq_generic_suspend, > > -#endif > > }; > > > > static int __init tegra_cpufreq_init(void) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, September 09, 2015 12:36:39 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote: > > On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote: > > > CONFIG_PM ifdefs are superfluous and can be removed. > > > > > > Cc: Stephen Warren <swarren@wwwdotorg.org> > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > What tree does this apply to? > > It applies fine to both next (next-20150909 branch) and current Linus' > tree (top commit is a794b4f). OK My cpufreq branch has not acquired tegra20-cpufreq.c yet, so I'll apply this one when -rc1 is out. Or please ask whoever merged that driver to apply it earlier if you want to. > > > --- > > > drivers/cpufreq/tegra20-cpufreq.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c > > > index 8084c7f..2bd6284 100644 > > > --- a/drivers/cpufreq/tegra20-cpufreq.c > > > +++ b/drivers/cpufreq/tegra20-cpufreq.c > > > @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = { > > > .exit = tegra_cpu_exit, > > > .name = "tegra", > > > .attr = cpufreq_generic_attr, > > > -#ifdef CONFIG_PM > > > .suspend = cpufreq_generic_suspend, > > > -#endif > > > }; > > > > > > static int __init tegra_cpufreq_init(void) > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics >
On Wednesday, September 09, 2015 10:14:50 PM Rafael J. Wysocki wrote: > On Wednesday, September 09, 2015 12:36:39 PM Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Wednesday, September 09, 2015 03:13:45 AM Rafael J. Wysocki wrote: > > > On Tuesday, September 08, 2015 07:13:23 PM Bartlomiej Zolnierkiewicz wrote: > > > > CONFIG_PM ifdefs are superfluous and can be removed. > > > > > > > > Cc: Stephen Warren <swarren@wwwdotorg.org> > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > > > What tree does this apply to? > > > > It applies fine to both next (next-20150909 branch) and current Linus' > > tree (top commit is a794b4f). > > OK > > My cpufreq branch has not acquired tegra20-cpufreq.c yet, so I'll apply this > one when -rc1 is out. Or please ask whoever merged that driver to apply it > earlier if you want to. Applied now, thanks! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c index 8084c7f..2bd6284 100644 --- a/drivers/cpufreq/tegra20-cpufreq.c +++ b/drivers/cpufreq/tegra20-cpufreq.c @@ -175,9 +175,7 @@ static struct cpufreq_driver tegra_cpufreq_driver = { .exit = tegra_cpu_exit, .name = "tegra", .attr = cpufreq_generic_attr, -#ifdef CONFIG_PM .suspend = cpufreq_generic_suspend, -#endif }; static int __init tegra_cpufreq_init(void)
CONFIG_PM ifdefs are superfluous and can be removed. Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Alexandre Courbot <gnurou@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/cpufreq/tegra20-cpufreq.c | 2 -- 1 file changed, 2 deletions(-)