From patchwork Wed Sep 9 00:12:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Dannenberg X-Patchwork-Id: 7143891 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AFDAE9F1BF for ; Wed, 9 Sep 2015 00:14:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AE1C320763 for ; Wed, 9 Sep 2015 00:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50F0B20709 for ; Wed, 9 Sep 2015 00:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754288AbbIIAOD (ORCPT ); Tue, 8 Sep 2015 20:14:03 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45818 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbbIIAOC (ORCPT ); Tue, 8 Sep 2015 20:14:02 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id t890De5x016027; Tue, 8 Sep 2015 19:13:40 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t890DeVo022552; Tue, 8 Sep 2015 19:13:40 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.224.2; Tue, 8 Sep 2015 19:13:32 -0500 Received: from beast.tx.rr.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t890D0S9019642; Tue, 8 Sep 2015 19:13:35 -0500 From: Andreas Dannenberg To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Laurentiu Palcu , Krzysztof Kozlowski CC: , , Andreas Dannenberg Subject: [PATCH v2 10/13] power: bq24257: Add various device-specific sysfs properties Date: Tue, 8 Sep 2015 19:12:34 -0500 Message-ID: <1441757557-7266-11-git-send-email-dannenberg@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1441757557-7266-1-git-send-email-dannenberg@ti.com> References: <1441757557-7266-1-git-send-email-dannenberg@ti.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds support to enable/disable some device specific features through device properties at boot time or sysfs properties at runtime depending on whether they should be accessible during runtime or not. The use of those features is be optional however they might be helpful in certain scenarios: * High-impedance mode enable/disable (through sysfs r/w) * Sysoff enable/disable (through sysfs r/w) * 2X Timer enable/disable (through "ti,safety-timer-2x-enable" dev property) If not explicitly modified those settings are left at their device- specific power-on defaults. Refer to the respectice device datasheets for more information: http://www.ti.com/product/bq24250 http://www.ti.com/product/bq24251 http://www.ti.com/product/bq24257 Signed-off-by: Andreas Dannenberg --- drivers/power/bq24257_charger.c | 75 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c index f0602b3..9a4a7a0 100644 --- a/drivers/power/bq24257_charger.c +++ b/drivers/power/bq24257_charger.c @@ -77,6 +77,7 @@ struct bq24257_init_data { u8 in_ilimit; /* input current limit */ u8 vovp; /* over voltage protection voltage */ u8 vindpm; /* VDMP input threshold voltage */ + bool timer2x_enable; /* slow down safety timer by 2x */ }; struct bq24257_state { @@ -766,6 +767,7 @@ static int bq24257_hw_init(struct bq24257_device *bq) {F_ITERM, bq->init_data.iterm}, {F_VOVP, bq->init_data.vovp}, {F_VINDPM, bq->init_data.vindpm}, + {F_X2_TMR_EN, bq->init_data.timer2x_enable}, }; /* @@ -860,12 +862,78 @@ static ssize_t bq24257_show_in_dpm_voltage(struct device *dev, bq24257_vindpm_map[bq->init_data.vindpm]); } +static ssize_t bq24257_sysfs_show_enable(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct power_supply *psy = dev_get_drvdata(dev); + struct bq24257_device *bq = power_supply_get_drvdata(psy); + int ret; + + mutex_lock(&bq->lock); + + if (strcmp(attr->attr.name, "high_impedance_enable") == 0) + ret = bq24257_field_read(bq, F_HZ_MODE); + else if (strcmp(attr->attr.name, "sysoff_enable") == 0) + ret = bq24257_field_read(bq, F_SYSOFF); + else if (strcmp(attr->attr.name, "timer2x_enable") == 0) + ret = bq->init_data.timer2x_enable; + else + ret = -EINVAL; + + mutex_unlock(&bq->lock); + + if (ret < 0) + return ret; + + return scnprintf(buf, PAGE_SIZE, "%d\n", ret); +} + +static ssize_t bq24257_sysfs_set_enable(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t count) +{ + struct power_supply *psy = dev_get_drvdata(dev); + struct bq24257_device *bq = power_supply_get_drvdata(psy); + long val; + int ret; + + if (kstrtol(buf, 10, &val) < 0) + return -EINVAL; + + mutex_lock(&bq->lock); + + if (strcmp(attr->attr.name, "high_impedance_enable") == 0) + ret = bq24257_field_write(bq, F_HZ_MODE, val); + else if (strcmp(attr->attr.name, "sysoff_enable") == 0) + ret = bq24257_field_write(bq, F_SYSOFF, val); + else + ret = -EINVAL; + + mutex_unlock(&bq->lock); + + if (ret < 0) + return ret; + + return count; +} + static DEVICE_ATTR(ovp_voltage, S_IRUGO, bq24257_show_ovp_voltage, NULL); static DEVICE_ATTR(in_dpm_voltage, S_IRUGO, bq24257_show_in_dpm_voltage, NULL); +static DEVICE_ATTR(high_impedance_enable, S_IWUSR | S_IRUGO, + bq24257_sysfs_show_enable, bq24257_sysfs_set_enable); +static DEVICE_ATTR(sysoff_enable, S_IWUSR | S_IRUGO, + bq24257_sysfs_show_enable, bq24257_sysfs_set_enable); +static DEVICE_ATTR(timer2x_enable, S_IRUGO, + bq24257_sysfs_show_enable, NULL); static struct attribute *bq24257_charger_attr[] = { &dev_attr_ovp_voltage.attr, &dev_attr_in_dpm_voltage.attr, + &dev_attr_high_impedance_enable.attr, + &dev_attr_sysoff_enable.attr, + &dev_attr_timer2x_enable.attr, NULL, }; @@ -973,6 +1041,13 @@ static int bq24257_fw_probe(struct bq24257_device *bq) bq->init_data.vindpm = bq24257_find_idx(property, bq24257_vindpm_map, BQ24257_VINDPM_MAP_SIZE); + ret = device_property_read_u32(bq->dev, "ti,safety-timer-2x-enable", + &property); + if (ret < 0) + bq->init_data.timer2x_enable = false; + else + bq->init_data.timer2x_enable = property; + return 0; }