From patchwork Tue Sep 15 17:58:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Dannenberg X-Patchwork-Id: 7188961 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BB9AF9F336 for ; Tue, 15 Sep 2015 17:59:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE3E520818 for ; Tue, 15 Sep 2015 17:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDD8F2081E for ; Tue, 15 Sep 2015 17:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbbIOR70 (ORCPT ); Tue, 15 Sep 2015 13:59:26 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:43952 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbbIOR7Y (ORCPT ); Tue, 15 Sep 2015 13:59:24 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id t8FHwxcw004313; Tue, 15 Sep 2015 12:58:59 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id t8FHwxJN011843; Tue, 15 Sep 2015 12:58:59 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.224.2; Tue, 15 Sep 2015 12:58:59 -0500 Received: from beast.tx.rr.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t8FHwdgT029416; Tue, 15 Sep 2015 12:58:56 -0500 From: Andreas Dannenberg To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Laurentiu Palcu , Krzysztof Kozlowski CC: Ramakrishna Pallala , , , Andreas Dannenberg Subject: [PATCH v4 05/10] power: bq24257: Add SW-based approach for Power Good determination Date: Tue, 15 Sep 2015 12:58:29 -0500 Message-ID: <1442339914-25843-6-git-send-email-dannenberg@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442339914-25843-1-git-send-email-dannenberg@ti.com> References: <1442339914-25843-1-git-send-email-dannenberg@ti.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A software-based approach for determining the charger's input voltage "Power Good" state is introduced for devices like the bq24250 which don't have a dedicated hardware pin for that purpose. This SW-based approach is also used for other devices (with dedicated PG pin) as a fall back solution if that pin is not configured to be used through "pg-gpios". Signed-off-by: Andreas Dannenberg Reviewed-by: Krzysztof Kozlowski --- drivers/power/bq24257_charger.c | 49 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c index 55e4ee4..d7488cf 100644 --- a/drivers/power/bq24257_charger.c +++ b/drivers/power/bq24257_charger.c @@ -103,6 +103,7 @@ struct bq24257_device { struct mutex lock; /* protect state data */ bool in_ilimit_autoset_disable; + bool pg_gpio_disable; }; static bool bq24257_is_volatile_reg(struct device *dev, unsigned int reg) @@ -356,7 +357,26 @@ static int bq24257_get_chip_state(struct bq24257_device *bq, state->fault = ret; - state->power_good = !gpiod_get_value_cansleep(bq->pg); + if (bq->pg_gpio_disable) + /* + * If we have a chip without a dedicated power-good GPIO or + * some other explicit bit that would provide this information + * assume the power is good if there is no supply related + * fault - and not good otherwise. There is a possibility for + * other errors to mask that power in fact is not good but this + * is probably the best we can do here. + */ + switch (state->fault) { + case FAULT_INPUT_OVP: + case FAULT_INPUT_UVLO: + case FAULT_INPUT_LDO_LOW: + state->power_good = false; + break; + default: + state->power_good = true; + } + else + state->power_good = !gpiod_get_value_cansleep(bq->pg); return 0; } @@ -676,7 +696,7 @@ static int bq24257_pg_gpio_probe(struct bq24257_device *bq) { bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN); if (IS_ERR(bq->pg)) { - dev_err(bq->dev, "could not probe PG pin\n"); + dev_info(bq->dev, "could not probe PG pin\n"); return PTR_ERR(bq->pg); } @@ -810,10 +830,27 @@ static int bq24257_probe(struct i2c_client *client, INIT_DELAYED_WORK(&bq->iilimit_setup_work, bq24257_iilimit_setup_work); - /* we can only check Power Good status by probing the PG pin */ - ret = bq24257_pg_gpio_probe(bq); - if (ret < 0) - return ret; + /* + * The BQ24250 doesn't have a dedicated Power Good (PG) pin so we + * explicitly disable this feature for this device and instead use + * a SW-based approach to determine the PG state. + */ + if (bq->chip == BQ24250) + bq->pg_gpio_disable = true; + + /* + * For devices that do have a dedicated PG pin go ahead and probe it, + * using the SW-based approach as a fall back solution. Note that the + * use of the dedicated pin is preferred. + */ + if (!bq->pg_gpio_disable) { + ret = bq24257_pg_gpio_probe(bq); + if (ret < 0) { + dev_info(bq->dev, + "using SW-based power-good detection\n"); + bq->pg_gpio_disable = true; + } + } /* reset all registers to defaults */ ret = bq24257_field_write(bq, F_RESET, 1);