From patchwork Mon Oct 19 14:26:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Insu Yun X-Patchwork-Id: 7437491 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CCEE49F37F for ; Mon, 19 Oct 2015 14:25:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D20B120430 for ; Mon, 19 Oct 2015 14:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E50B32039D for ; Mon, 19 Oct 2015 14:25:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753701AbbJSOZe (ORCPT ); Mon, 19 Oct 2015 10:25:34 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:34962 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698AbbJSOZe (ORCPT ); Mon, 19 Oct 2015 10:25:34 -0400 Received: by ykaz22 with SMTP id z22so141426471yka.2; Mon, 19 Oct 2015 07:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=oCUpeSn0tNA9ZvxdckvQ4ctEcPIcLFBAslgKr/h5JTg=; b=t8FKfN/6IrsPJGvDsC/atnMkYmI2FQwS1rPS/2OYHtB6JkEkJ4GVAS6eyQP8ldrCla jbna2bXjnKSp9XbfTygNXEZsoYIM5qG96QqPDLWEXEmBilTvdO9vnUzHkh1Rrq3tzJnt f9vJyM2ANvqtlck/sO8IBHNdCHqwPinHcLn2OrqwGahfm4wN/rjAseNQYU/S/B2HiiuP HQYOpeV68dv+62Tdp8A4ioIyAsnMGGSDZB6yHMBlVf/oHkZ6pS7ephgocEu1i1eBzX32 3QVCfWRfWHWne3TIJYvcF2CGQD+cWGd/RyQax1vL5VCNN2iJVLhgA+tbzS+z0aM8DI4+ GOZA== X-Received: by 10.129.71.67 with SMTP id u64mr20333369ywa.82.1445264733356; Mon, 19 Oct 2015 07:25:33 -0700 (PDT) Received: from cutthroat.gtisc.gatech.edu (cutthroat.gtisc.gatech.edu. [128.61.240.77]) by smtp.gmail.com with ESMTPSA id b186sm26354505ywc.53.2015.10.19.07.25.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Oct 2015 07:25:32 -0700 (PDT) From: Insu Yun To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Insu Yun Subject: [PATCH] devfreq: correctly check failed allocation Date: Mon, 19 Oct 2015 14:26:49 +0000 Message-Id: <1445264809-21917-1-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since devm_kzalloc can be failed in memory pressure, check return value and handle error. Signed-off-by: Insu Yun --- drivers/devfreq/devfreq.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index ca1b362..814089f 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -482,9 +482,23 @@ struct devfreq *devfreq_add_device(struct device *dev, devfreq->profile->max_state * devfreq->profile->max_state, GFP_KERNEL); + if (!devfreq->trans_table) { + dev_err(dev, "%s: Unable to create transition table for the device\n", + __func__); + err = -ENOMEM; + goto err_dev; + } + devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) * devfreq->profile->max_state, GFP_KERNEL); + if (!devfreq->time_in_state) { + dev_err(dev, "%s: Unable to create state for the device\n", + __func__); + err = -ENOMEM; + goto err_dev; + } + devfreq->last_stat_updated = jiffies; dev_set_name(&devfreq->dev, "%s", dev_name(dev));