From patchwork Thu Oct 22 08:47:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 7463061 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B04799F30B for ; Thu, 22 Oct 2015 08:47:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EA3F32076E for ; Thu, 22 Oct 2015 08:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 104DC209A4 for ; Thu, 22 Oct 2015 08:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756958AbbJVIrq (ORCPT ); Thu, 22 Oct 2015 04:47:46 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55555 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756949AbbJVIrn (ORCPT ); Thu, 22 Oct 2015 04:47:43 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1ZpBXA-00056v-0D; Thu, 22 Oct 2015 10:47:40 +0200 Received: from sha by dude.hi.pengutronix.de with local (Exim 4.86) (envelope-from ) id 1ZpBX9-0002c3-38; Thu, 22 Oct 2015 10:47:39 +0200 From: Sascha Hauer To: linux-arm-kernel@lists.infradead.org Cc: "Rafael J . Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, Shawn Guo , kernel@pengutronix.de, Heiner Kallweit , Sascha Hauer Subject: [PATCH 2/4] cpufreq: imx6q: Fix wrong device in devm_kzalloc Date: Thu, 22 Oct 2015 10:47:30 +0200 Message-Id: <1445503652-777-3-git-send-email-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1445503652-777-1-git-send-email-s.hauer@pengutronix.de> References: <1445503652-777-1-git-send-email-s.hauer@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_kzalloc must be called with the device that is actually probed, not with cpu_dev which resources are not freed when probe fails. Signed-off-by: Sascha Hauer Reviewed-by: Lucas Stach --- drivers/cpufreq/imx6q-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index fabd144..7557d1e 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) } /* Make imx6_soc_volt array's size same as arm opp number */ - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); + imx6_soc_volt = devm_kzalloc(&pdev->dev, + sizeof(*imx6_soc_volt) * num, GFP_KERNEL); if (imx6_soc_volt == NULL) { ret = -ENOMEM; goto free_freq_table;