From patchwork Tue Nov 10 02:58:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: srinivas pandruvada X-Patchwork-Id: 7587721 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DEA32C05C6 for ; Tue, 10 Nov 2015 02:59:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 247E8206AD for ; Tue, 10 Nov 2015 02:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F58620684 for ; Tue, 10 Nov 2015 02:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbbKJC7E (ORCPT ); Mon, 9 Nov 2015 21:59:04 -0500 Received: from mga03.intel.com ([134.134.136.65]:48368 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbbKJC7E (ORCPT ); Mon, 9 Nov 2015 21:59:04 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 09 Nov 2015 18:59:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,268,1444719600"; d="scan'208";a="846624279" Received: from spandruv-desk3.jf.intel.com ([10.7.199.153]) by orsmga002.jf.intel.com with ESMTP; 09 Nov 2015 18:59:04 -0800 From: Srinivas Pandruvada To: rafael.j.wysocki@intel.com, lenlenb@kernel.org Cc: linux-pm@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 1/3] cpufreq: intel_pstate: Don't use ACPI perf for HWP Date: Mon, 9 Nov 2015 18:58:09 -0800 Message-Id: <1447124291-14059-2-git-send-email-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1447124291-14059-1-git-send-email-srinivas.pandruvada@linux.intel.com> References: <1447124291-14059-1-git-send-email-srinivas.pandruvada@linux.intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When HWP is enabled, the information in _PSS and _PPC prevents entering turbo states. The reason is HWP and legacy pstate are not compatible. There is no processing of turbo activation ratio in HWP, but _PPC setting still behaves as there is support. So we end up in a pstate, which is below or equal to max non turbo ratio. Also the max turbo ratio is set to wrong value in _PSS, so even if HWP is disabled to use acpi-cpufrq or intel_pstate in legacy mode, this will still cause issue. This change will not read any _PSS table or call acpi_processor_register_performance, when the platform has HWP feature. Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 93a3c63..a0b8180 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -1557,8 +1557,11 @@ static int __init intel_pstate_init(void) if (!all_cpu_data) return -ENOMEM; - if (static_cpu_has_safe(X86_FEATURE_HWP) && !no_hwp) - hwp_active++; + if (static_cpu_has_safe(X86_FEATURE_HWP)) { + if (!no_hwp) + hwp_active++; + no_acpi_perf = 1; + } if (!hwp_active && hwp_only) goto out;