From patchwork Fri Nov 13 09:29:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Dubey X-Patchwork-Id: 7609361 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3993BBF90C for ; Fri, 13 Nov 2015 09:36:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 66BBF20524 for ; Fri, 13 Nov 2015 09:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 873AF204D6 for ; Fri, 13 Nov 2015 09:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbbKMJci (ORCPT ); Fri, 13 Nov 2015 04:32:38 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:54744 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbbKMJce (ORCPT ); Fri, 13 Nov 2015 04:32:34 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NXQ02A68YI6BX50@mailout3.samsung.com>; Fri, 13 Nov 2015 18:32:30 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.123]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 7E.F8.05272.E2EA5465; Fri, 13 Nov 2015 18:32:30 +0900 (KST) X-AuditID: cbfee68e-f791c6d000001498-fb-5645ae2ed843 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 12.DC.18629.E2EA5465; Fri, 13 Nov 2015 18:32:30 +0900 (KST) Received: from chromebld-server.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NXQ002KAYHMWY40@mmp1.samsung.com>; Fri, 13 Nov 2015 18:32:30 +0900 (KST) From: Pankaj Dubey To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: kgene.kim@samsung.com, k.kozlowski@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com, olof@lixom.net, khilman@linaro.org, arnd@arndb.de, Pankaj Dubey Subject: [PATCH v5 2/9] ARM: EXYNOS: Fix potential NULL pointer access in exynos_sys_powerdown_conf Date: Fri, 13 Nov 2015 14:59:36 +0530 Message-id: <1447406983-27835-3-git-send-email-pankaj.dubey@samsung.com> X-Mailer: git-send-email 2.4.5 In-reply-to: <1447406983-27835-1-git-send-email-pankaj.dubey@samsung.com> References: <1447406983-27835-1-git-send-email-pankaj.dubey@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsWyRsSkWldvnWuYwblX0hYfV79ks/g76Ri7 xesXhha9C66yWXw9vILRYtPja6wWl3fNYbP43HuE0WLG+X1MFqeuf2azWLT1C7tFxzJGBx6P 378mMXrsnHWX3ePOtT1sHpuX1HtcOdHE6tG3ZRWjx+dNcgHsUVw2Kak5mWWpRfp2CVwZjdu6 WQpWc1Q86/7H1MDYyd7FyMkhIWAicWLOORYIW0ziwr31bF2MXBxCAisYJT63n2SEKTo58Rob iC0ksJRRYtEpJoiiViaJW69vsoIk2AR0JZ68n8sMkhARaGWUWLb/P1gVs8ABRokd616BjRIW SJX4u+0OUAcHB4uAqkT/OjcQk1fAQ2LW9QQQU0JATmJpcy1IMaeAp8TzqQuZIfZ6SBxfeJYR ZKKEwDl2ibfT+8AOYhEQkPg2+RALRK+sxKYDzBA3S0ocXHGDZQKj8AJGhlWMoqkFyQXFSelF RnrFibnFpXnpesn5uZsYgVFy+t+zvh2MNw9YH2IU4GBU4uHd8cIlTIg1say4MvcQoynQhonM UqLJ+cBYzCuJNzQ2M7IwNTE1NjK3NFMS502Q+hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1Oq gZH59evEAPYVWyf4znJwzf8/8/zH7fpcSyXWfUj+Y/wwcyqn5Z1HR3XP1ezcfjW6o2VNkXPw TE/tlZ4Wc1rc5/+3nfjQIztoQsUD//NrP/z+W7rpl9D0FOGoFY1Md+arfFI+cuvV2w9LFZul Zm9X3/W+a2qL+VImie03Q+5s8DZZW3VoHmvkHv8LSizFGYmGWsxFxYkAjQPhiI0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t9jAV29da5hBnsfilh8XP2SzeLvpGPs Fq9fGFr0LrjKZvH18ApGi02Pr7FaXN41h83ic+8RRosZ5/cxWZy6/pnNYtHWL+wWHcsYHXg8 fv+axOixc9Zddo871/aweWxeUu9x5UQTq0ffllWMHp83yQWwRzUw2mSkJqakFimk5iXnp2Tm pdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA3amkUJaYUwoUCkgsLlbSt8M0ITTE TdcCpjFC1zckCK7HyAANJKxhzGjc1s1SsJqj4ln3P6YGxk72LkZODgkBE4mTE6+xQdhiEhfu rQezhQSWMkosOsXUxcgFZLcySdx6fZMVJMEmoCvx5P1cZpCEiEAro8Sy/f/BqpgFDjBK7Fj3 ihGkSlggVeLvtjtAHRwcLAKqEv3r3EBMXgEPiVnXE0BMCQE5iaXNtSDFnAKeEs+nLmSG2Osh cXzhWcYJjLwLGBlWMUqkFiQXFCel5xrlpZbrFSfmFpfmpesl5+duYgRH4jPpHYyHd7kfYhTg YFTi4d3xwiVMiDWxrLgy9xCjBAezkgjv4mdAId6UxMqq1KL8+KLSnNTiQ4ymQFdNZJYSTc4H Jom8knhDYxNzU2NTSxMLEzNLJXFefU+jMCGB9MSS1OzU1ILUIpg+Jg5OqQbGnp3XuZKs/BIE Nj+bfnly4lemcmZ+9ubri+eu+O0osknE8dDRxgRHYSM5ffbFxbXLkoMvWFnxFEfuCzp7lzdm q5Pt3mWVnzXXxKtM3y6iUd/BOi9R3FFv4q2qa7evTTq3wSPk16z89V8EP2WnxUrpvspfcNXb fN0RZYVLNivt9NYuvKfm/MRBiaU4I9FQi7moOBEAqfysFdoCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If no platform devices binded to the driver but driver itself loaded and exynos_sys_powerdown_conf is called from arch/arm/mach-exynos/{suspend.c, pm.c} it will result in NULL pointer access, to prevent this added check on pmu_context for NULL. Signed-off-by: Pankaj Dubey Reviewed-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/pmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c index 64ea7d6..d40f7e9 100644 --- a/arch/arm/mach-exynos/pmu.c +++ b/arch/arm/mach-exynos/pmu.c @@ -749,8 +749,12 @@ static void exynos5_powerdown_conf(enum sys_powerdown mode) void exynos_sys_powerdown_conf(enum sys_powerdown mode) { unsigned int i; + const struct exynos_pmu_data *pmu_data; + + if (!pmu_context) + return; - const struct exynos_pmu_data *pmu_data = pmu_context->pmu_data; + pmu_data = pmu_context->pmu_data; if (pmu_data->powerdown_conf) pmu_data->powerdown_conf(mode);