| Message ID | 1447463821-14595-2-git-send-email-srinivas.pandruvada@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Friday, November 13, 2015 05:17:01 PM Srinivas Pandruvada wrote: > When the no_acpi_perf is set to 1, that means that we haven't called > acpi_processor_register_performance(), so we shouldn't also call > acpi_processor_unregister_performance in intel_pstate_exit_perf_limits(). > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> OK, but this is my patch. :-) I'll apply it with the right From: line. > --- > drivers/cpufreq/intel_pstate.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 6ec39ef..bad1ee3 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -326,13 +326,9 @@ static int intel_pstate_init_perf_limits(struct cpufreq_policy *policy) > > static int intel_pstate_exit_perf_limits(struct cpufreq_policy *policy) > { > - struct cpudata *cpu; > - > if (!no_acpi_perf) > - return 0; > + acpi_processor_unregister_performance(policy->cpu); > > - cpu = all_cpu_data[policy->cpu]; > - acpi_processor_unregister_performance(policy->cpu); > return 0; > } > > Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 6ec39ef..bad1ee3 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -326,13 +326,9 @@ static int intel_pstate_init_perf_limits(struct cpufreq_policy *policy) static int intel_pstate_exit_perf_limits(struct cpufreq_policy *policy) { - struct cpudata *cpu; - if (!no_acpi_perf) - return 0; + acpi_processor_unregister_performance(policy->cpu); - cpu = all_cpu_data[policy->cpu]; - acpi_processor_unregister_performance(policy->cpu); return 0; }
When the no_acpi_perf is set to 1, that means that we haven't called acpi_processor_register_performance(), so we shouldn't also call acpi_processor_unregister_performance in intel_pstate_exit_perf_limits(). Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> --- drivers/cpufreq/intel_pstate.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)