From patchwork Mon Nov 23 13:06:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: plongepe X-Patchwork-Id: 7680981 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6DFCCBF90C for ; Mon, 23 Nov 2015 13:06:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F6E820718 for ; Mon, 23 Nov 2015 13:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2774206D6 for ; Mon, 23 Nov 2015 13:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753897AbbKWNGL (ORCPT ); Mon, 23 Nov 2015 08:06:11 -0500 Received: from mga09.intel.com ([134.134.136.24]:40543 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbbKWNGL (ORCPT ); Mon, 23 Nov 2015 08:06:11 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 23 Nov 2015 05:05:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,337,1444719600"; d="scan'208";a="857572082" Received: from tllab185.tl.intel.com ([10.102.161.63]) by orsmga002.jf.intel.com with ESMTP; 23 Nov 2015 05:05:48 -0800 From: Philippe Longepe To: linux-pm@vger.kernel.org Cc: srinivas.pandruvada@linux.intel.com, Philippe Longepe Subject: [PATCH v1 1/5] cpufreq: intel_pstate: change function name for calculation for busy Date: Mon, 23 Nov 2015 14:06:37 +0100 Message-Id: <1448284006-13596-3-git-send-email-philippe.longepe@linux.intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1448284006-13596-1-git-send-email-philippe.longepe@linux.intel.com> References: <1448284006-13596-1-git-send-email-philippe.longepe@linux.intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Philippe Longepe APERF/MPERF is not giving busy but average performance of frequency. Also core_pct_busy is not busy but core percent for performance. Signed-off-by: Srinivas Pandruvada Signed-off-by: Philippe Longepe --- drivers/cpufreq/intel_pstate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index d3b0e50..423a12a 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -65,7 +65,7 @@ static inline int ceiling_fp(int32_t x) } struct sample { - int32_t core_pct_busy; + int32_t core_pct_perf; u64 aperf; u64 mperf; u64 tsc; @@ -856,7 +856,7 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate, false); } -static inline void intel_pstate_calc_busy(struct cpudata *cpu) +static inline void intel_pstate_calc_performance(struct cpudata *cpu) { struct sample *sample = &cpu->sample; int64_t core_pct; @@ -870,7 +870,7 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu) cpu->pstate.scaling / 100), core_pct)); - sample->core_pct_busy = (int32_t)core_pct; + sample->core_pct_perf = (int32_t)core_pct; } static inline void intel_pstate_sample(struct cpudata *cpu) @@ -899,7 +899,7 @@ static inline void intel_pstate_sample(struct cpudata *cpu) cpu->sample.mperf -= cpu->prev_mperf; cpu->sample.tsc -= cpu->prev_tsc; - intel_pstate_calc_busy(cpu); + intel_pstate_calc_performance(cpu); cpu->prev_aperf = aperf; cpu->prev_mperf = mperf; @@ -939,7 +939,7 @@ static inline int32_t intel_pstate_get_scaled_busy(struct cpudata *cpu) * period. The result will be a percentage of busy at a * specified pstate. */ - core_busy = cpu->sample.core_pct_busy; + core_busy = cpu->sample.core_pct_perf; max_pstate = int_tofp(cpu->pstate.max_pstate_physical); current_pstate = int_tofp(cpu->pstate.current_pstate); core_busy = mul_fp(core_busy, div_fp(max_pstate, current_pstate)); @@ -982,7 +982,7 @@ static inline void intel_pstate_adjust_busy_pstate(struct cpudata *cpu) intel_pstate_set_pstate(cpu, cpu->pstate.current_pstate - ctl, true); sample = &cpu->sample; - trace_pstate_sample(fp_toint(sample->core_pct_busy), + trace_pstate_sample(fp_toint(sample->core_pct_perf), fp_toint(busy_scaled), from, cpu->pstate.current_pstate,