| Message ID | 1448424468-18736-1-git-send-email-edubezval@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Eduardo Valentin |
| Headers | show |
SGksDQpPbiBUdWUsIDIwMTUtMTEtMjQgYXQgMjA6MDcgLTA4MDAsIEVkdWFyZG8gVmFsZW50aW4g d3JvdGU6DQo+IEluc3RlYWQgb2YgY2hhbmdpbmcgdGhlIG1vbml0b3Jpbmcgc2V0dXAgZXZlcnkg dGltZSBhZnRlcg0KPiBoYW5kbGluZyBlYWNoIHRyaXAsIHRoaXMgcGF0Y2ggc2ltcGxpZmllcyB0 aGUgbW9uaXRvcmluZw0KPiBzZXR1cCBieSBtb3ZpbmcgdGhlIHNldHVwIGNhbGwgdG8gYSBwbGFj ZSB3aGVyZSBhbGwNCj4gdHJpcHMgaGF2ZSBiZWVuIHRyZWF0ZWQgYWxyZWFkeS4NCj4gDQo+IENj OiBaaGFuZyBSdWkgPHJ1aS56aGFuZ0BpbnRlbC5jb20+DQo+IENjOiBsaW51eC1wbUB2Z2VyLmtl cm5lbC5vcmcNCj4gQ2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4gU2lnbmVkLW9m Zi1ieTogRWR1YXJkbyBWYWxlbnRpbiA8ZWR1YmV6dmFsQGdtYWlsLmNvbT4NCj4gLS0tDQo+ICBk cml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmMgfCAxMSArKysrKystLS0tLQ0KPiAgMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmMgYi9kcml2ZXJzL3RoZXJtYWwvdGhl cm1hbF9jb3JlLmMNCj4gaW5kZXggZDllNTI1Yy4uNmRlYmI1NCAxMDA2NDQNCj4gLS0tIGEvZHJp dmVycy90aGVybWFsL3RoZXJtYWxfY29yZS5jDQo+ICsrKyBiL2RyaXZlcnMvdGhlcm1hbC90aGVy bWFsX2NvcmUuYw0KPiBAQCAtNDU3LDExICs0NTcsNiBAQCBzdGF0aWMgdm9pZCBoYW5kbGVfdGhl cm1hbF90cmlwKHN0cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNlICp0eiwgaW50IHRyaXApDQo+ICAJ CWhhbmRsZV9jcml0aWNhbF90cmlwcyh0eiwgdHJpcCwgdHlwZSk7DQo+ICAJZWxzZQ0KPiAgCQlo YW5kbGVfbm9uX2NyaXRpY2FsX3RyaXBzKHR6LCB0cmlwLCB0eXBlKTsNCj4gLQkvKg0KPiAtCSAq IEFscmlnaHQsIHdlIGhhbmRsZWQgdGhpcyB0cmlwIHN1Y2Nlc3NmdWxseS4NCj4gLQkgKiBTbywg c3RhcnQgbW9uaXRvcmluZyBhZ2Fpbi4NCj4gLQkgKi8NCj4gLQltb25pdG9yX3RoZXJtYWxfem9u ZSh0eik7DQo+ICB9DQo+ICANCj4gIC8qKg0KPiBAQCAtNTQ3LDYgKzU0MiwxMiBAQCB2b2lkIHRo ZXJtYWxfem9uZV9kZXZpY2VfdXBkYXRlKHN0cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNlICp0eikN Cj4gIA0KPiAgCWZvciAoY291bnQgPSAwOyBjb3VudCA8IHR6LT50cmlwczsgY291bnQrKykNCj4g IAkJaGFuZGxlX3RoZXJtYWxfdHJpcCh0eiwgY291bnQpOw0KPiArDQo+ICsJLyoNCj4gKwkgKiBB bHJpZ2h0LCB3ZSBoYW5kbGVkIHRoaXMgdHJpcCBzdWNjZXNzZnVsbHkuDQpzL3RoZXNlIHRyaXBz ID8NCj4gKwkgKiBTbywgc3RhcnQgbW9uaXRvcmluZyBhZ2Fpbi4NCj4gKwkgKi8NCj4gKwltb25p dG9yX3RoZXJtYWxfem9uZSh0eik7DQo+ICB9DQo+ICBFWFBPUlRfU1lNQk9MX0dQTCh0aGVybWFs X3pvbmVfZGV2aWNlX3VwZGF0ZSk7DQo+ICANCkJUVywgdGhlcm1hbF9ub3RpZnlfZnJhbWV3b3Jr IG1pZ2h0IG5lZWQgYmUgYWZmZWN0ZWQ/IA0KDQp0aGFua3MsDQpZdQ0K -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 25, 2015 at 07:16:08AM +0000, Chen, Yu C wrote: > Hi, > On Tue, 2015-11-24 at 20:07 -0800, Eduardo Valentin wrote: > > Instead of changing the monitoring setup every time after > > handling each trip, this patch simplifies the monitoring > > setup by moving the setup call to a place where all > > trips have been treated already. > > > > Cc: Zhang Rui <rui.zhang@intel.com> > > Cc: linux-pm@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Eduardo Valentin <edubezval@gmail.com> > > --- > > drivers/thermal/thermal_core.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > > index d9e525c..6debb54 100644 > > --- a/drivers/thermal/thermal_core.c > > +++ b/drivers/thermal/thermal_core.c > > @@ -457,11 +457,6 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) > > handle_critical_trips(tz, trip, type); > > else > > handle_non_critical_trips(tz, trip, type); > > - /* > > - * Alright, we handled this trip successfully. > > - * So, start monitoring again. > > - */ > > - monitor_thermal_zone(tz); > > } > > > > /** > > @@ -547,6 +542,12 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) > > > > for (count = 0; count < tz->trips; count++) > > handle_thermal_trip(tz, count); > > + > > + /* > > + * Alright, we handled this trip successfully. > s/these trips ? Yeah, I can amend this. > > + * So, start monitoring again. > > + */ > > + monitor_thermal_zone(tz); > > } > > EXPORT_SYMBOL_GPL(thermal_zone_device_update); > > > BTW, thermal_notify_framework might need be affected? Well, the original code does not call thermal_notify_framework. Calling it would require a different patch. This one is just to simplify the monitoring setup. BR, > > thanks, > Yu -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index d9e525c..6debb54 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -457,11 +457,6 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip) handle_critical_trips(tz, trip, type); else handle_non_critical_trips(tz, trip, type); - /* - * Alright, we handled this trip successfully. - * So, start monitoring again. - */ - monitor_thermal_zone(tz); } /** @@ -547,6 +542,12 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) for (count = 0; count < tz->trips; count++) handle_thermal_trip(tz, count); + + /* + * Alright, we handled this trip successfully. + * So, start monitoring again. + */ + monitor_thermal_zone(tz); } EXPORT_SYMBOL_GPL(thermal_zone_device_update);
Instead of changing the monitoring setup every time after handling each trip, this patch simplifies the monitoring setup by moving the setup call to a place where all trips have been treated already. Cc: Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <edubezval@gmail.com> --- drivers/thermal/thermal_core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)