From patchwork Tue Apr 26 06:47:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 8934991 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7E754BF29F for ; Tue, 26 Apr 2016 06:47:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EEE54201BB for ; Tue, 26 Apr 2016 06:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB33F20172 for ; Tue, 26 Apr 2016 06:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbcDZGrc (ORCPT ); Tue, 26 Apr 2016 02:47:32 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:32806 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbcDZGrb (ORCPT ); Tue, 26 Apr 2016 02:47:31 -0400 Received: by mail-lf0-f41.google.com with SMTP id y84so5446916lfc.0 for ; Mon, 25 Apr 2016 23:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ray5nVd63SjvVsMhiEECcw2Zv+p/nzizwpki4iEIqtw=; b=UFL9OkOzEC6T40MGlrFCWadnNgCoyFqiQ5ZeG7Z4Bf4orAsU73fByrOv2HSde8zSYZ 5L3VFEiFONzaUer8NnEOwJ81D4deRF8spXgRY21cctdxDG3UceLVxumWbKCKh1BvgbwL k5bX1y60L9UqMv1kUgDoO+WmRTUpbwl4WqYrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ray5nVd63SjvVsMhiEECcw2Zv+p/nzizwpki4iEIqtw=; b=W5lDxScPmdnx38jdg7g3NX6uTBCEJmaQBBthF54e6t5wPduv2XAs5acRkWMNOJ+DU0 ciwv1bQNXtTFJIx9PkisGzrvaS6yiEZc/eU72bgXqrdlSJ+hwMqeNlXMBGwnxc8gZ6sU LMQ+7VfI5QET3LLFtj4saQ9lrgDol7eCQCen7EFQxuSMB9Oqd6v2DwtnUdJ6I8SkXX0U plJurHewUwCX9jD7+xgQ8FZHAEJIpFEsV/PfO1fetRtPsqWm375UuokLvynZVY9IsCOJ to/VAb+dHTFdapQODCMVcZl78midgwBph8qu3faozBHIVt3lUrV6lCYM9LCkElManc95 /avw== X-Gm-Message-State: AOPr4FVEtMMXImNKolQnrApTFda9F9ls9+rljdEAtk8yHQAV82rl7+GN+05NZCNr8vrjlhIa X-Received: by 10.25.147.77 with SMTP id v74mr532270lfd.19.1461653250112; Mon, 25 Apr 2016 23:47:30 -0700 (PDT) Received: from localhost.localdomain (h-155-4-128-67.na.cust.bahnhof.se. [155.4.128.67]) by smtp.gmail.com with ESMTPSA id p199sm2248306lfd.12.2016.04.25.23.47.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2016 23:47:28 -0700 (PDT) From: Ulf Hansson To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org Cc: Len Brown , Pavel Machek , Geert Uytterhoeven , Lina Iyer , Axel Haslam , Marek Szyprowski , Jon Hunter , Andy Gross , Laurent Pinchart Subject: [PATCH v2 1/2] PM / Domains: Remove redundant pm_runtime_get|put*() in pm_genpd_prepare() Date: Tue, 26 Apr 2016 08:47:17 +0200 Message-Id: <1461653238-3891-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461653238-3891-1-git-send-email-ulf.hansson@linaro.org> References: <1461653238-3891-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The PM core increases and decreases the runtime PM usage count in the system PM prepare phase. This makes some of the pm_runtime_get|put*() calls in pm_gendp_prepare() redundant, so let's remove them. Signed-off-by: Ulf Hansson Reviewed-by: Kevin Hilman Reviewed-by: Laurent Pinchart Reviewed-by: Laurent Pinchart --- Changes in v2: Updated changlog and added Kevin's reviewed by. --- drivers/base/power/domain.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 4ce4ce0..60a3573 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -730,14 +730,11 @@ static int pm_genpd_prepare(struct device *dev) * at this point and a system wakeup event should be reported if it's * set up to wake up the system from sleep states. */ - pm_runtime_get_noresume(dev); if (pm_runtime_barrier(dev) && device_may_wakeup(dev)) pm_wakeup_event(dev, 0); - if (pm_wakeup_pending()) { - pm_runtime_put(dev); + if (pm_wakeup_pending()) return -EBUSY; - } if (resume_needed(dev, genpd)) pm_runtime_resume(dev); @@ -751,10 +748,8 @@ static int pm_genpd_prepare(struct device *dev) mutex_unlock(&genpd->lock); - if (genpd->suspend_power_off) { - pm_runtime_put_noidle(dev); + if (genpd->suspend_power_off) return 0; - } /* * The PM domain must be in the GPD_STATE_ACTIVE state at this point, @@ -776,7 +771,6 @@ static int pm_genpd_prepare(struct device *dev) pm_runtime_enable(dev); } - pm_runtime_put(dev); return ret; }