From patchwork Fri May 27 08:23:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9137855 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D4FAD6075A for ; Fri, 27 May 2016 08:24:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C46D52780C for ; Fri, 27 May 2016 08:24:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B8DC328093; Fri, 27 May 2016 08:24:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CB682780C for ; Fri, 27 May 2016 08:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932805AbcE0IYH (ORCPT ); Fri, 27 May 2016 04:24:07 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36817 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932583AbcE0IYC (ORCPT ); Fri, 27 May 2016 04:24:02 -0400 Received: by mail-pf0-f194.google.com with SMTP id g132so5179520pfb.3; Fri, 27 May 2016 01:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5ON2t+PcpEoX2t8Ms4TQgvLcsxBbkVbB8cp+bPcEipY=; b=gC12BfiTqZTztTlAsTteHZekzZU245TCl7Qr5gYIySFtXts1U9Ofo4tkVEX9v70zgq xmjy1SsL+PzpyKx1HE02PxCj7lHPnzBWS2LbxPIC6T4J/lgungoteQuhr+oWvMfW8duf d/8k7A8C2E/Iy4dCPvwSEoPJyA9kPlVX7Qd7jKGJ5rJ/F2Ep8cbmb324vKmPToCWqFQx opLYrLTaEerwlSMa8EI/QSs+iy5yCbdMtereYloXlXSKE0wYBccqoKNx00b1j+EFvTMP xOB7LYRmrR9xnY6jx8JYNtMPf5dwRxjHZVUzIcp92wOM2MOtyJtkabfOF6/Q89mm1a6f l2tg== X-Gm-Message-State: ALyK8tLnOLIlAmmBzspc1gvzyizDZ8TOoKqn9o5bCqYiBbOcwhZjHc+IBbsQAWqxIdeexA== X-Received: by 10.98.21.82 with SMTP id 79mr18009223pfv.92.1464337435980; Fri, 27 May 2016 01:23:55 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id w27sm11551805pfi.24.2016.05.27.01.23.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 May 2016 01:23:54 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net, Sascha Hauer , Caesar Wang , Zhang Rui , linux-kernel@vger.kernel.org Subject: [PATCH v4 3/4] thermal: bang-bang governor: act on lower trip boundary Date: Fri, 27 May 2016 16:23:27 +0800 Message-Id: <1464337408-7123-4-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464337408-7123-1-git-send-email-wxt@rock-chips.com> References: <1464337408-7123-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v4: None Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index 70836c5..9d1dfea 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",