From patchwork Fri May 27 08:36:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9137889 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A36D6075C for ; Fri, 27 May 2016 08:38:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EFE827CCD for ; Fri, 27 May 2016 08:38:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2379128093; Fri, 27 May 2016 08:38:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA8AE27CCD for ; Fri, 27 May 2016 08:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932835AbcE0IhW (ORCPT ); Fri, 27 May 2016 04:37:22 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:33640 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932756AbcE0IhS (ORCPT ); Fri, 27 May 2016 04:37:18 -0400 Received: by mail-pa0-f68.google.com with SMTP id f8so11907295pag.0; Fri, 27 May 2016 01:37:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5ON2t+PcpEoX2t8Ms4TQgvLcsxBbkVbB8cp+bPcEipY=; b=WZbSLg/zaYUg1JKnJ0O9RUZdv1j9cuISUH+NY2Orxp2yVVNSZn3QmC8T/7OCoN9dbC xqBd5yeGHoQ/Can/AzIXlL4f6OpZEhpdLAzw3mDGMobHSpRsXnYE5HFhLpPfSryPwTtT lAdm00N/R7esT6nUBOmDhTQKd98XNKukKb+eoLlG6n2vk91LbBzg2kyV4Nzb6TBbqZUK irISHTFtZVZglvO7rk6iGqcMxqNRuaxfKsfHNDXjrGvp47tig2+lPk/LxZ9/ExlQhj/l ZTHHesPmWjH+DrmyA1fxMjrgkB5IKZYBzP5pmtRxXoEBriGQrrpDEYgeXMG/aE0znDWZ w9FA== X-Gm-Message-State: ALyK8tLMoqYLnoWODUOY2QW9kdpdvYYy+T5rYLXKKtaywwc5r/V5yAKxXkPkBP5SHbPSOg== X-Received: by 10.66.249.74 with SMTP id ys10mr20653419pac.16.1464338237383; Fri, 27 May 2016 01:37:17 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id x19sm11624932pfi.81.2016.05.27.01.37.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 May 2016 01:37:16 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net, Sascha Hauer , Caesar Wang , Zhang Rui , linux-kernel@vger.kernel.org Subject: [RESEND PATCH v4 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Fri, 27 May 2016 16:36:47 +0800 Message-Id: <1464338208-8105-5-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464338208-8105-1-git-send-email-wxt@rock-chips.com> References: <1464338208-8105-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v4: None Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index 70836c5..9d1dfea 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",