From patchwork Mon May 30 09:33:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 9140785 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2115360759 for ; Mon, 30 May 2016 09:33:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11F06281B4 for ; Mon, 30 May 2016 09:33:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 069A628212; Mon, 30 May 2016 09:33:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ADF02281B4 for ; Mon, 30 May 2016 09:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413AbcE3Jd1 (ORCPT ); Mon, 30 May 2016 05:33:27 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34625 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754307AbcE3Jd0 (ORCPT ); Mon, 30 May 2016 05:33:26 -0400 Received: by mail-lf0-f54.google.com with SMTP id k98so69927103lfi.1 for ; Mon, 30 May 2016 02:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f/5rtxPj88e4itPpEZIG4OldDHfpvCl+RQ6sxmyzZWY=; b=SDQP5QqLgwTs8rSoowHJkCbVtgDbHYurra0LOI3JUiviwI1z2E46/C6fTvKmFkrcEt RhkJM+3C++mj8hz+aTuQLW+Nl3W5esgKm+fgYYcfNdx0bxzpTxQJAyoNM+be0fj4LVus 3QX0uKFM+Ll4QuuNOfWr/aGtR6l/N1yn3cxG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f/5rtxPj88e4itPpEZIG4OldDHfpvCl+RQ6sxmyzZWY=; b=RcAaMyOUYyd5wC2UyfYUAP073TfYY7hfvrHdxC3E/lVsmETkobowlbMoO8JOE+1ZuD xUVXRfAFZ7acL5+TgbUgb/zedbnPIUxyAFtjuk5WY/g0ldF/OoYZBddBrpYGlVkzgzNo X7LPL1zXoUlIZyL1N9lQqP8m1i+zAI5nwar0l/N30Kkfp2IhvyrRcq6IjO3+gt96cpIP BDZzt7+PGdANtcaEZyDEd6cf6tq2xPrzcB7k/qeJtU6dt9r8LD4ljIIlfyijsREWiQA9 vPH+jTgnZ56/2XBe476UEHqLyRJ9UI7VhymQiOQPvDL8e5XrXSFdO1exIWSQtlFhXbwc CUQQ== X-Gm-Message-State: ALyK8tKX0upfDkknqjggjDfpw0cXnUFYVveG7Y7hHDUSz/wkq3cLXBaT6wXda8Qyu4G4nnnD X-Received: by 10.25.24.65 with SMTP id o62mr6980987lfi.23.1464600804686; Mon, 30 May 2016 02:33:24 -0700 (PDT) Received: from uffe-Latitude-E6430s.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 75sm4596853lfw.25.2016.05.30.02.33.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 May 2016 02:33:23 -0700 (PDT) From: Ulf Hansson To: "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-pm@vger.kernel.org Cc: Len Brown , Pavel Machek , Geert Uytterhoeven , Lina Iyer , Axel Haslam , Marek Szyprowski , Jon Hunter , Andy Gross , Laurent Pinchart Subject: [PATCH v2 1/5] PM / Domains: Remove redundant call to pm_request_idle() in genpd Date: Mon, 30 May 2016 11:33:11 +0200 Message-Id: <1464600795-26307-2-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464600795-26307-1-git-send-email-ulf.hansson@linaro.org> References: <1464600795-26307-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The PM core increases the runtime PM usage count at the system PM prepare phase. Later when the system resumes, it does a pm_runtime_put() in the complete phase, which in addition to decrementing the usage count, does the equivalent of a pm_request_idle(). Therefore the call to pm_request_idle() from within genpd's ->complete() callback is redundant, so let's remove it. Signed-off-by: Ulf Hansson Reviewed-by: Kevin Hilman --- Changes in v2: - Updated changelog. --- drivers/base/power/domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 658eb1b..60a9971 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -938,7 +938,6 @@ static void pm_genpd_complete(struct device *dev) pm_generic_complete(dev); pm_runtime_set_active(dev); pm_runtime_enable(dev); - pm_request_idle(dev); } /**