From patchwork Mon Jun 6 11:44:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9157933 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E32B60467 for ; Mon, 6 Jun 2016 11:46:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3084826907 for ; Mon, 6 Jun 2016 11:46:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 256C92780C; Mon, 6 Jun 2016 11:46:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A796626907 for ; Mon, 6 Jun 2016 11:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbcFFLpy (ORCPT ); Mon, 6 Jun 2016 07:45:54 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34245 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbcFFLp0 (ORCPT ); Mon, 6 Jun 2016 07:45:26 -0400 Received: by mail-pa0-f66.google.com with SMTP id ug1so1674151pab.1; Mon, 06 Jun 2016 04:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NHWu8PO9sxJ/B+qpESovpaTYCzleF7SLdX+LiSV2xxE=; b=TL3Yqd8ZFL/y+yr8TNq0Bdf8PewWEiPa2mZcrej1a8nGldObDzCDNwWCu195gYgf5l Qp1xP0ibfzQkTdeZs4fRLSXVJBYn9ByRM4EjmWGmHpg0Wa4zbJpH4iEHM9rGdzINGt9b SRcMCeUtUSULe/5KZyoESyckANqBm4UFcbhNFjbDg6mHascRcPuHbBmvK9SCbcLFmzvC KnjF6M+yqChXQTqTMhyzaNsrb/YMzQiYHGZyIYSWhv0v5ANNMGYdGwZmOeba+NmOisUU oxtAUbClACfLPUg60fO6LKn4WMD2/Vxxn5c60dhV6llcDAaNGUXN4QKXXxTSGnSB1/Du 3zwg== X-Gm-Message-State: ALyK8tIvJ8lu/VgtdoViOsXlW8Ih1FtXt5T6doYSS636V2r/EYaSiv3rlPX01c9yi8affw== X-Received: by 10.66.157.193 with SMTP id wo1mr24437747pab.116.1465213525193; Mon, 06 Jun 2016 04:45:25 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id g82sm27196446pfj.22.2016.06.06.04.45.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jun 2016 04:45:24 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net, Sascha Hauer , Caesar Wang , Zhang Rui , linux-kernel@vger.kernel.org Subject: [PATCH v5 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Mon, 6 Jun 2016 19:44:48 +0800 Message-Id: <1465213489-14898-5-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465213489-14898-1-git-send-email-wxt@rock-chips.com> References: <1465213489-14898-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v5: None Changes in v4: None Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index fc52016..5073871 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -65,7 +65,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",