diff mbox

[v3,7/7] doc: bindings: act8945a-charger: Update properties

Message ID 1469755528-8413-8-git-send-email-wenyou.yang@atmel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Wenyou Yang July 29, 2016, 1:25 a.m. UTC
Due the driver improvements, update the properties,
 - Remove "active-semi,check-battery-temperature" property.
 - Add the properties, "active-semi,irq_gpio"
   and "active-semi,lbo-gpios".

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

Changes in v3: None
Changes in v2: None

 Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Rob Herring (Arm) July 29, 2016, 9:40 p.m. UTC | #1
On Fri, Jul 29, 2016 at 09:25:28AM +0800, Wenyou Yang wrote:
> Due the driver improvements, update the properties,
>  - Remove "active-semi,check-battery-temperature" property.
>  - Add the properties, "active-semi,irq_gpio"
>    and "active-semi,lbo-gpios".
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> index bea254c..d7cf05b 100644
> --- a/Documentation/devicetree/bindings/power/act8945a-charger.txt
> +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt
> @@ -4,10 +4,12 @@ Required properties:
>   - compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt.
>   - active-semi,chglev-gpios: charge current level phandle with args
>     as described in ../gpio/gpio.txt.
> + - active-semi,irq_gpios: specify the charger interrupt input phanle
> +   with args as as described in ../gpio/gpio.txt.

As I said in v2, this should be an interrupt property instead.

> + - active-semi,lbo-gpios: specify the low battery voltage detect phandle
> +   with args as as described in ../gpio/gpio.txt.

Maybe this one too.

>  
>  Optional properties:
> - - active-semi,check-battery-temperature: boolean to check the battery
> -   temperature or not.
>   - active-semi,input-voltage-threshold-microvolt: unit: mV;
>     Specifies the charger's input over-voltage threshold value;
>     The value can be: 6600, 7000, 7500, 8000; default: 6600
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wenyou.Yang@microchip.com Aug. 8, 2016, 6:05 a.m. UTC | #2
Hi Rob,

> -----Original Message-----

> From: Rob Herring [mailto:robh@kernel.org]

> Sent: 2016年7月30日 5:40

> To: Wenyou Yang <wenyou.yang@atmel.com>

> Cc: Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov

> <dbaryshkov@gmail.com>; David Woodhouse <dwmw2@infradead.org>; Pawel

> Moll <pawel.moll@arm.com>; Mark Brown <broonie@kernel.org>; Ian Campbell

> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; linux-

> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-

> kernel@lists.infradead.org; Nicolas Ferre <nicolas.ferre@atmel.com>; linux-

> pm@vger.kernel.org

> Subject: Re: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties

> 

> On Fri, Jul 29, 2016 at 09:25:28AM +0800, Wenyou Yang wrote:

> > Due the driver improvements, update the properties,

> >  - Remove "active-semi,check-battery-temperature" property.

> >  - Add the properties, "active-semi,irq_gpio"

> >    and "active-semi,lbo-gpios".

> >

> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

> > ---

> >

> > Changes in v3: None

> > Changes in v2: None

> >

> >  Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++--

> >  1 file changed, 4 insertions(+), 2 deletions(-)

> >

> > diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt

> b/Documentation/devicetree/bindings/power/act8945a-charger.txt

> > index bea254c..d7cf05b 100644

> > --- a/Documentation/devicetree/bindings/power/act8945a-charger.txt

> > +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt

> > @@ -4,10 +4,12 @@ Required properties:

> >   - compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt.

> >   - active-semi,chglev-gpios: charge current level phandle with args

> >     as described in ../gpio/gpio.txt.

> > + - active-semi,irq_gpios: specify the charger interrupt input phanle

> > +   with args as as described in ../gpio/gpio.txt.

> 

> As I said in v2, this should be an interrupt property instead.


Sorry for forgetting to change.

Accepted, will be in next version. Thanks.

> 

> > + - active-semi,lbo-gpios: specify the low battery voltage detect phandle

> > +   with args as as described in ../gpio/gpio.txt.

> 

> Maybe this one too.


The capacity level function need to read this pin level, so this one should not
use "interrupts" property.

> 

> >

> >  Optional properties:

> > - - active-semi,check-battery-temperature: boolean to check the battery

> > -   temperature or not.

> >   - active-semi,input-voltage-threshold-microvolt: unit: mV;

> >     Specifies the charger's input over-voltage threshold value;

> >     The value can be: 6600, 7000, 7500, 8000; default: 6600

> > --

> > 2.7.4

> >


Best Regards,
Wenyou Yang
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt b/Documentation/devicetree/bindings/power/act8945a-charger.txt
index bea254c..d7cf05b 100644
--- a/Documentation/devicetree/bindings/power/act8945a-charger.txt
+++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt
@@ -4,10 +4,12 @@  Required properties:
  - compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt.
  - active-semi,chglev-gpios: charge current level phandle with args
    as described in ../gpio/gpio.txt.
+ - active-semi,irq_gpios: specify the charger interrupt input phanle
+   with args as as described in ../gpio/gpio.txt.
+ - active-semi,lbo-gpios: specify the low battery voltage detect phandle
+   with args as as described in ../gpio/gpio.txt.
 
 Optional properties:
- - active-semi,check-battery-temperature: boolean to check the battery
-   temperature or not.
  - active-semi,input-voltage-threshold-microvolt: unit: mV;
    Specifies the charger's input over-voltage threshold value;
    The value can be: 6600, 7000, 7500, 8000; default: 6600