| Message ID | 1473208539-17685-1-git-send-email-hugh.kang@lge.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
On 07-09-16, 09:35, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. > > Signed-off-by: Inhyuk Kang <hugh.kang@lge.com> > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index a32b417..9ce0e9e 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -74,7 +74,7 @@ struct power_table { > * cpufreq frequencies. > * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device. > * @node: list_head to link all cpufreq_cooling_device together. > - * @last_load: load measured by the latest call to cpufreq_get_actual_power() > + * @last_load: load measured by the latest call to cpufreq_get_requested_power() > * @time_in_idle: previous reading of the absolute time that this cpu was idle > * @time_in_idle_timestamp: wall time of the last invocation of > * get_cpu_idle_time_us() Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang <hugh.kang@lge.com> Acked-by: Javi Merino <javi.merino@arm.com> > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index a32b417..9ce0e9e 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -74,7 +74,7 @@ struct power_table { > * cpufreq frequencies. > * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device. > * @node: list_head to link all cpufreq_cooling_device together. > - * @last_load: load measured by the latest call to cpufreq_get_actual_power() > + * @last_load: load measured by the latest call to cpufreq_get_requested_power() > * @time_in_idle: previous reading of the absolute time that this cpu was idle > * @time_in_idle_timestamp: wall time of the last invocation of > * get_cpu_idle_time_us() > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
You're welcome. Will be merged this patch? Thank you Hugh Kang No One ever is defeated until defeat has been accepted as a reality. 강인혁 (Hugh Kang) Chief Engineer SW Platform(연) Advanced OS Technology TEAM (AOT) Mobile: +82-10-5513-7957 -----Original Message----- From: Javi Merino [mailto:javi.merino@arm.com] Sent: Thursday, September 08, 2016 5:26 PM To: Inhyuk Kang Cc: Viresh Kumar; amit.kachhap@gmail.com; linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; Eduardo Valentin; Rui Zhang Subject: Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang <hugh.kang@lge.com> Acked-by: Javi Merino <javi.merino@arm.com> > diff --git a/drivers/thermal/cpu_cooling.c > b/drivers/thermal/cpu_cooling.c index a32b417..9ce0e9e 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -74,7 +74,7 @@ struct power_table { > * cpufreq frequencies. > * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device. > * @node: list_head to link all cpufreq_cooling_device together. > - * @last_load: load measured by the latest call to > cpufreq_get_actual_power() > + * @last_load: load measured by the latest call to > + cpufreq_get_requested_power() > * @time_in_idle: previous reading of the absolute time that this cpu was idle > * @time_in_idle_timestamp: wall time of the last invocation of > * get_cpu_idle_time_us() > -- > 1.9.1 >
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index a32b417..9ce0e9e 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -74,7 +74,7 @@ struct power_table { * cpufreq frequencies. * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device. * @node: list_head to link all cpufreq_cooling_device together. - * @last_load: load measured by the latest call to cpufreq_get_actual_power() + * @last_load: load measured by the latest call to cpufreq_get_requested_power() * @time_in_idle: previous reading of the absolute time that this cpu was idle * @time_in_idle_timestamp: wall time of the last invocation of * get_cpu_idle_time_us()
The last_load is updated not cpufreq_get_actual_power() function call but cpufreq_get_requested_power() function call. Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>