From patchwork Thu Oct 20 06:59:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 9386029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 427B860762 for ; Thu, 20 Oct 2016 06:58:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FF3E293AE for ; Thu, 20 Oct 2016 06:58:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23A9329ABD; Thu, 20 Oct 2016 06:58:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F520293AE for ; Thu, 20 Oct 2016 06:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbcJTG6E (ORCPT ); Thu, 20 Oct 2016 02:58:04 -0400 Received: from conuserg-12.nifty.com ([210.131.2.79]:22655 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcJTG6D (ORCPT ); Thu, 20 Oct 2016 02:58:03 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id u9K6vOex023088; Thu, 20 Oct 2016 15:57:24 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com u9K6vOex023088 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1476946645; bh=G4YY+1jrpNDu+AbkFWNUgcBkzOq9/euQratR334Um/4=; h=From:To:Cc:Subject:Date:From; b=zCJSHWFSNPXdsrnw2mIarr8XBTBpeKvx4wfsH2rJfRM3NGzEkoaGLDZDCI+wMWqHG qxf8lT+MNRpnmjW96M9yeEKWe4eZ4eqto6A1f4n2rp7GhaXRhgrQF/a3gkL4hD4fsI cksU3IGFlqd6e16BlQ12D+OvR5HNEf2b0vQvTcRGwOHYYxDnpGIXPkdH/z9g3n5Iic +lW5n04YeZaSwBhjIU7r6f0opJadheMQjcjgCOzQnXgq4mIgFDL6xva4XX2lscmDqN oGA8IGXQbFU/frwQshcdMlnGZTIwPjOMPsbImpwhzmxtIyR3jnBoUtEqJ5z7aLqGdx FcQkkCAKzXTUg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-pm@vger.kernel.org Cc: Masahiro Yamada , Stephen Boyd , linux-kernel@vger.kernel.org, Nishanth Menon , Len Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pavel Machek , Viresh Kumar Subject: [PATCH v2] PM / OPP: fix debug/error messages in dev_pm_opp_of_get_sharing_cpus() Date: Thu, 20 Oct 2016 15:59:56 +0900 Message-Id: <1476946796-27698-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These log messages are wrong because _of_get_opp_desc_node() returns an operating-points-v2 node. Commit a6eed752f5fb ("PM / OPP: passing NULL to PTR_ERR()") fixed static checker warnings, and reworded the messages at the same time (but the latter was not mentioned in the git-log). Restore the correct messages, dropping __func__. We can grep the message string, so the function name would not carry much value. Signed-off-by: Masahiro Yamada --- Changes in v2: - Reword git-log slightly comments -> log messages drivers/base/power/opp/of.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 6480137..92e6d53 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -562,7 +562,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ np = _of_get_opp_desc_node(cpu_dev); if (!np) { - dev_dbg(cpu_dev, "%s: Couldn't find cpu_dev node.\n", __func__); + dev_dbg(cpu_dev, "Couldn't find opp node.\n"); return -ENOENT; } @@ -587,8 +587,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, /* Get OPP descriptor node */ tmp_np = _of_get_opp_desc_node(tcpu_dev); if (!tmp_np) { - dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n", - __func__); + dev_err(tcpu_dev, "Couldn't find opp node.\n"); ret = -ENOENT; goto put_cpu_node; }